crypto keygen benchmark failing after OpenSSL 3.0 upgrade

[mscdex]

Version

master

Platform

Linux foo 5.4.0-58-generic #64~18.04.1-Ubuntu SMP Wed Dec 9 17:11:11 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Subsystem

crypto

What steps will reproduce the bug?

Run the crypto/keygen benchmark.

How often does it reproduce? Is there a required condition?

No response

What is the expected behavior?

No response

What do you see instead?

No response

Additional information

Stack trace:

node:internal/crypto/keygen:110
    throw err;
    ^

Error: error:05000072:dsa routines::bad ffc parameters
    at generateKeyPairSync (node:internal/crypto/keygen:101:63)
    at Object.dsaSync (/home/bench/node/benchmark/crypto/keygen.js:45:7)
    at main (/home/bench/node/benchmark/crypto/keygen.js:70:18)
    at /home/bench/node/benchmark/common.js:42:9
    at processTicksAndRejections (node:internal/process/task_queues:78:11)

I guess we should be putting some of these function calls from the benchmark into our existing crypto tests to catch things like this in the future?

/cc @nodejs/crypto

[richardlau]

I guess we should be putting some of these function calls from the benchmark into our existing crypto tests to catch things like this in the future?

I thought our normal CI runs did a basic check that our benchmarks worked? e.g. I would have expected https://github.com/nodejs/node/blob/master/test/benchmark/test-benchmark-crypto.js to flag this... unless we're running them without going once through the loop (n==0?)?