Typo in fetch_module - "[stdin" instead of "[stdin]"? #41922
Comments
scovetta
changed the title
|
That looks to be indeed incorrect, would you like to send a PR to fix that? |
scovetta
added a commit
to scovetta/node
that referenced
this issue
Feb 10, 2022
This PR fixes a minor typo in fetchModule's check for `[eval]` and `[stdin]` parent names.
aduh95
pushed a commit
that referenced
this issue
Feb 12, 2022
This PR fixes a minor typo in fetchModule's check for `[eval]` and `[stdin]` parent names. PR-URL: #41924 Fixes: #41922 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
bengl
pushed a commit
to bengl/node
that referenced
this issue
Feb 21, 2022
This PR fixes a minor typo in fetchModule's check for `[eval]` and `[stdin]` parent names. PR-URL: nodejs#41924 Fixes: nodejs#41922 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
bengl
pushed a commit
that referenced
this issue
Feb 22, 2022
This PR fixes a minor typo in fetchModule's check for `[eval]` and `[stdin]` parent names. PR-URL: #41924 Fixes: #41922 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
danielleadams
pushed a commit
to danielleadams/node
that referenced
this issue
Apr 21, 2022
This PR fixes a minor typo in fetchModule's check for `[eval]` and `[stdin]` parent names. PR-URL: nodejs#41924 Fixes: nodejs#41922 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
danielleadams
pushed a commit
that referenced
this issue
Apr 24, 2022
This PR fixes a minor typo in fetchModule's check for `[eval]` and `[stdin]` parent names. PR-URL: #41924 Fixes: #41922 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Version
(master)
Platform
n/a
Subsystem
n/a
What steps will reproduce the bug?
Affected file:
https://github.com/nodejs/node/blob/master/lib/internal/modules/esm/fetch_module.js#L270
I noticed what looks like a minor bug in the recently merged https imports PR:
(I think
[stdinshould be[stdin].)Happy to send over a PR, but I don't have a lot of context -- my apologies if this is intentional.
How often does it reproduce? Is there a required condition?
n/a
What is the expected behavior?
n/a
What do you see instead?
n/a
Additional information
n/a
The text was updated successfully, but these errors were encountered: