Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: HTML API docs' fixed header obscures anchored content #42286

Closed
mscdex opened this issue Mar 10, 2022 · 1 comment · Fixed by #42165 or #45131
Closed

doc: HTML API docs' fixed header obscures anchored content #42286

mscdex opened this issue Mar 10, 2022 · 1 comment · Fixed by #42165 or #45131
Labels
doc Issues and PRs related to the documentations.

Comments

@mscdex
Copy link
Contributor

mscdex commented Mar 10, 2022

Version

n/a

Platform

n/a

Subsystem

doc

What steps will reproduce the bug?

Go to the v17.7.0 docs in any section and click one of the links in the list of links at the top of the page. Example.

How often does it reproduce? Is there a required condition?

No response

What is the expected behavior?

The fixed header should not cover/obscure the content I jumped to.

What do you see instead?

The fixed header covers/obscures the content I jumped to.

Additional information

I tested this on Firefox (97). For some odd reason Chrome (98) doesn't utilize a fixed header at all.
@mscdex mscdex added the doc Issues and PRs related to the documentations. label Mar 10, 2022
@aduh95 aduh95 mentioned this issue Mar 11, 2022
Merged
nodejs-github-bot pushed a commit that referenced this issue Mar 22, 2022
@ShogunPanda
doc: make header smaller and dropdown click-driven when JS is on
0f79a27 
PR-URL: #42165
Fixes: #42286
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
juanarbol pushed a commit that referenced this issue Apr 4, 2022
@ShogunPanda @juanarbol
doc: make header smaller and dropdown click-driven when JS is on
c89ed0c 
PR-URL: #42165
Fixes: #42286
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
juanarbol pushed a commit to juanarbol/node that referenced this issue Apr 5, 2022
@ShogunPanda @juanarbol
doc: make header smaller and dropdown click-driven when JS is on
89da27c 
PR-URL: nodejs#42165
Fixes: nodejs#42286
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
juanarbol pushed a commit that referenced this issue Apr 6, 2022
@ShogunPanda @juanarbol
doc: make header smaller and dropdown click-driven when JS is on
00f693b 
PR-URL: #42165
Fixes: #42286
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
xtx1130 pushed a commit to xtx1130/node that referenced this issue Apr 25, 2022
@ShogunPanda @xtx1130
doc: make header smaller and dropdown click-driven when JS is on
a7b9085 
PR-URL: nodejs#42165
Fixes: nodejs#42286
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
juanarbol pushed a commit that referenced this issue May 31, 2022
@ShogunPanda @juanarbol
doc: make header smaller and dropdown click-driven when JS is on
54720f5 
PR-URL: #42165
Fixes: #42286
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this issue Jun 27, 2022
@ShogunPanda @danielleadams
doc: make header smaller and dropdown click-driven when JS is on
2048082 
PR-URL: #42165
Fixes: #42286
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit that referenced this issue Jul 11, 2022
@ShogunPanda @targos
doc: make header smaller and dropdown click-driven when JS is on
5b5295f 
PR-URL: #42165
Fixes: #42286
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit that referenced this issue Jul 31, 2022
@ShogunPanda @targos
doc: make header smaller and dropdown click-driven when JS is on
d9ae6c7 
PR-URL: #42165
Fixes: #42286
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@targos
Copy link
Member

targos commented Aug 3, 2022

This doesn't seem fixed to me: https://nodejs.org/dist/latest-v18.x/docs/api/util.html#utilparseargsconfig

@targos targos reopened this Aug 3, 2022
guangwong pushed a commit to noslate-project/node that referenced this issue Oct 10, 2022
@ShogunPanda @guangwong
doc: make header smaller and dropdown click-driven when JS is on
e820a08 
PR-URL: nodejs/node#42165
Fixes: nodejs/node#42286
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@mscdex mscdex mentioned this issue Oct 23, 2022
Merged
nodejs-github-bot pushed a commit that referenced this issue May 16, 2024
@cloydlau
doc: avoid hiding by navigation bar in anchor jumping
b0bd534 
PR-URL: #45131
Fixes: #42286
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit that referenced this issue May 21, 2024
@cloydlau @targos
doc: avoid hiding by navigation bar in anchor jumping
4c65c52 
PR-URL: #45131
Fixes: #42286
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
EliphazBouye pushed a commit to EliphazBouye/node that referenced this issue Jun 20, 2024
@cloydlau @EliphazBouye
doc: avoid hiding by navigation bar in anchor jumping
ed2a511 
PR-URL: nodejs#45131
Fixes: nodejs#42286
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
bmeck pushed a commit to bmeck/node that referenced this issue Jun 22, 2024
@cloydlau @bmeck
doc: avoid hiding by navigation bar in anchor jumping
45a6d88 
PR-URL: nodejs#45131
Fixes: nodejs#42286
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
marco-ippolito pushed a commit that referenced this issue Jul 19, 2024
@cloydlau @marco-ippolito
doc: avoid hiding by navigation bar in anchor jumping
862cbac 
PR-URL: #45131
Fixes: #42286
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
marco-ippolito pushed a commit that referenced this issue Jul 19, 2024
@cloydlau @marco-ippolito
doc: avoid hiding by navigation bar in anchor jumping
2854585 
PR-URL: #45131
Fixes: #42286
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
2 participants
@mscdex @targos