-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linked modules do not get added to the built-in modules #42302
Labels
Comments
Hi, |
richardlau
added
confirmed-bug
Issues with confirmed bugs.
build
Issues and PRs related to build files or the CI.
and removed
windows
Issues and PRs related to the Windows platform.
labels
Jun 22, 2023
richardlau
added
lts-watch-v16.x
lts-watch-v18.x
PRs that may need to be released in v18.x.
and removed
lts-watch-v16.x
lts-watch-v18.x
PRs that may need to be released in v18.x.
labels
Jun 22, 2023
nodejs-github-bot
pushed a commit
that referenced
this issue
Jun 24, 2023
Add the list of linked modules to the arguments for `js2c.py`. These were unintentionally omitted when the build was previously refactored to avoid command line length limits on Windows. PR-URL: #48522 Fixes: #42302 Refs: #39069 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS
pushed a commit
that referenced
this issue
Jul 3, 2023
Add the list of linked modules to the arguments for `js2c.py`. These were unintentionally omitted when the build was previously refactored to avoid command line length limits on Windows. PR-URL: #48522 Fixes: #42302 Refs: #39069 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this issue
Aug 14, 2023
Add the list of linked modules to the arguments for `js2c.py`. These were unintentionally omitted when the build was previously refactored to avoid command line length limits on Windows. PR-URL: nodejs#48522 Fixes: nodejs#42302 Refs: nodejs#39069 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this issue
Aug 14, 2023
Add the list of linked modules to the arguments for `js2c.py`. These were unintentionally omitted when the build was previously refactored to avoid command line length limits on Windows. PR-URL: nodejs#48522 Fixes: nodejs#42302 Refs: nodejs#39069 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this issue
Oct 28, 2023
Add the list of linked modules to the arguments for `js2c.py`. These were unintentionally omitted when the build was previously refactored to avoid command line length limits on Windows. PR-URL: #48522 Fixes: #42302 Refs: #39069 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
sercher
added a commit
to sercher/graaljs
that referenced
this issue
Apr 25, 2024
Add the list of linked modules to the arguments for `js2c.py`. These were unintentionally omitted when the build was previously refactored to avoid command line length limits on Windows. PR-URL: nodejs/node#48522 Fixes: nodejs/node#42302 Refs: nodejs/node#39069 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
sercher
added a commit
to sercher/graaljs
that referenced
this issue
Apr 25, 2024
Add the list of linked modules to the arguments for `js2c.py`. These were unintentionally omitted when the build was previously refactored to avoid command line length limits on Windows. PR-URL: nodejs/node#48522 Fixes: nodejs/node#42302 Refs: nodejs/node#39069 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Version
v17.7.0
Platform
Windows
Subsystem
No response
What steps will reproduce the bug?
Compile NodeJS and add a linked module by e.g. using this command:
How often does it reproduce? Is there a required condition?
No response
What is the expected behavior?
The module should be available as a built-in module when using the resulting binary.
What do you see instead?
The file is missing from the file generated by the
js2c
script, presumably by faulty refactoring done in the past. (It still worked with NodeJS v14)Additional information
No response
The text was updated successfully, but these errors were encountered: