Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typeof os.networkInterfaces family is a number (v18.0.0) #42861

Closed
elecV2 opened this issue Apr 25, 2022 · 2 comments
Closed

typeof os.networkInterfaces family is a number (v18.0.0) #42861

elecV2 opened this issue Apr 25, 2022 · 2 comments
Labels
doc Issues and PRs related to the documentations. os Issues and PRs related to the os subsystem.

Comments

@elecV2
Copy link

elecV2 commented Apr 25, 2022 •
edited
Loading

Affected URL(s)

https://nodejs.org/dist/latest-v18.x/docs/api/os.html#osnetworkinterfaces

Description of the problem

according to this commit: 3a26db9 , the type of os.networkInterfaces family is an integer now, but the api doc still show as string.

Another problem about this change, some functions of package require('ip') may not working. error message: details.family.toLowerCase is not a function

detail code: https://github.com/indutny/node-ip/blob/master/lib/ip.js#L385

(Just bring it up incase someone get the same error
@elecV2 elecV2 added the doc Issues and PRs related to the documentations. label Apr 25, 2022
@VoltrexKeyva VoltrexKeyva added the os Issues and PRs related to the os subsystem. label Apr 25, 2022
@VoltrexKeyva VoltrexKeyva changed the title typeof os.networkInterfaces family is a number (v18.0.0 typeof os.networkInterfaces family is a number (v18.0.0) Apr 25, 2022
@VoltrexKeyva
Copy link
Member

This was already mentioned in #42787 and was fixed in #42789, it can take a while for the website to update and show the changes.

@elecV2
Copy link
Author

elecV2 commented Apr 25, 2022

This was already mentioned in #42787 and was fixed in #42789, it can take a while for the website to update and show the changes.

I see. 👍
Thanks reply.

@elecV2 elecV2 closed this as completed Apr 25, 2022
@y1d7ng y1d7ng mentioned this issue Apr 29, 2022
Closed
zhangyuheng added a commit to zhangyuheng/address that referenced this issue Apr 29, 2022
@zhangyuheng
feat: address.ip() supports node 18
1c54255 
- typeof os.networkInterfaces family is a number (v18.0.0)

@see nodejs/node#42861
@zhangyuheng zhangyuheng mentioned this issue Apr 29, 2022
Merged
zhangyuheng added a commit to zhangyuheng/address that referenced this issue Apr 29, 2022
@zhangyuheng
feat: address.ip() supports node 18
13cefa1 
- typeof os.networkInterfaces family is a number (v18.0.0)

@see nodejs/node#42861
fengmk2 pushed a commit to node-modules/address that referenced this issue Apr 29, 2022
@zhangyuheng
feat: address.ip() supports node 18 (#26)
fe81a41 
- typeof os.networkInterfaces family is a number (v18.0.0)

@see nodejs/node#42861

closes #25
@mscdex mscdex mentioned this issue Apr 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. os Issues and PRs related to the os subsystem.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@elecV2 @VoltrexKeyva