Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test-debug-no-context segfaulting #4343

Closed
mscdex opened this issue Dec 18, 2015 · 7 comments
Closed

test-debug-no-context segfaulting #4343

mscdex opened this issue Dec 18, 2015 · 7 comments
Labels
arm Issues and PRs related to the ARM platform. test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform.

Comments

@mscdex
Copy link
Contributor

mscdex commented Dec 18, 2015

It looks like there may be more needed than 25776f3 to keep test-debug-no-context from segfaulting as I just noticed tonight that it segfaulted on two separate occasions (here and here).

/cc @bnoordhuis @jasnell @evanlucas @nodejs/platform-windows
@mscdex mscdex added debugger windows Issues and PRs related to the Windows platform. test Issues and PRs related to the tests. labels Dec 18, 2015
@Trott
Copy link
Member

Trott commented Dec 25, 2015

Here's another one: https://ci.nodejs.org/job/node-test-binary-windows/388/RUN_SUBSET=1,VS_VERSION=vs2015,label=win10/console

Probably time to mark this one as flaky. I'll get a PR in for that...

@Trott Trott mentioned this issue Dec 25, 2015
Closed
Trott added a commit to Trott/io.js that referenced this issue Dec 25, 2015
@Trott
test: mark test-debug-no-context is flaky
21610bb 
test-debug-no-context is flaky on Windows. Mark as such.

Ref: nodejs#4343
PR-URL: nodejs#4421
Reviewed-By: Brian White <mscdex@mscdex.net>
Trott added a commit to Trott/io.js that referenced this issue Dec 28, 2015
@Trott
test: mark test-debug-no-context is flaky
d09c447 
test-debug-no-context is flaky on Windows. Mark as such.

Ref: nodejs#4343
PR-URL: nodejs#4421
Reviewed-By: Brian White <mscdex@mscdex.net>
Fishrock123 pushed a commit to Fishrock123/node that referenced this issue Jan 6, 2016
@Trott @Fishrock123
test: mark test-debug-no-context is flaky
c639d0f 
test-debug-no-context is flaky on Windows. Mark as such.

Ref: nodejs#4343
PR-URL: nodejs#4421
Reviewed-By: Brian White <mscdex@mscdex.net>
@Trott Trott mentioned this issue Jan 7, 2016
Closed
@bnoordhuis
Copy link
Member

Has anyone been able to reproduce the crash locally? AssertionError: 3221225477 === 0 means the child process died with a 0xC0000005 error (i.e., an access violation) so there is probably still a missing (Windows-only?) nullptr check somewhere.

/cc @nodejs/platform-windows

@Trott Trott mentioned this issue Jan 11, 2016
Closed
Trott added a commit to Trott/io.js that referenced this issue Jan 17, 2016
@Trott
test: mark test-debug-no-context is flaky
1f3d61c 
test-debug-no-context is flaky on Windows. Mark as such.

Ref: nodejs#4343
PR-URL: nodejs#4421
Reviewed-By: Brian White <mscdex@mscdex.net>
@Trott Trott mentioned this issue Jan 17, 2016
Closed
jasnell pushed a commit that referenced this issue Jan 18, 2016
@Trott @jasnell
test: mark test-debug-no-context is flaky
12db976 
test-debug-no-context is flaky on Windows. Mark as such.

Ref: #4343
PR-URL: #4421
Reviewed-By: Brian White <mscdex@mscdex.net>
MylesBorins pushed a commit that referenced this issue Jan 19, 2016
@Trott
test: mark test-debug-no-context is flaky
f61412c 
test-debug-no-context is flaky on Windows. Mark as such.

Ref: #4343
PR-URL: #4421
Reviewed-By: Brian White <mscdex@mscdex.net>
@Trott Trott mentioned this issue Jan 26, 2016
Closed
@Trott
Copy link
Member

Trott commented Jan 30, 2016

Two more of these today:

@Trott Trott added the arm Issues and PRs related to the ARM platform. label Feb 6, 2016
@Trott
Copy link
Member

Trott commented Feb 6, 2016

This test is also flaky on pi2-raspbian-wheezy although there it times out rather than seg faults.

@Trott
Copy link
Member

Trott commented Feb 11, 2016

Another one:

This issue seems to come up on CI on the win10 hosts especially. Other than being win10, I'm not sure if there's anything different about those hosts from the other Windows hosts on CI. (It always seems to be the Azure hosts, but I'm not sure we have win10 hosts anywhere else.) /cc @nodejs/build

@Trott
Copy link
Member

Trott commented Feb 12, 2016

@bnoordhuis If it helps locate where the null pointer might be hiding, removing the util.inspect( Promise.resolve()) lines (and corresponding assertions confirming Promise { } text in the output) mean the access violation never happens.

And if that's obvious or otherwise not useful, eh, never mind...

@Trott
Copy link
Member

Trott commented Feb 14, 2016

Also: If the --debug and --debug-port options are removed, the test is no longer flaky on Windows 10. Again, not sure if that's particularly helpful or not...

@Trott Trott mentioned this issue Feb 17, 2016
Closed
Trott added a commit to Trott/io.js that referenced this issue Feb 17, 2016
@Trott
test: mitigate flaky test-debug-no-context
67a13ca 
Change test so that it passes on the occasional win10 access violation.

The workaround here can be undone when issue 5268 is resolved.

The test still detects the defect it was written to detect. There are
two assertions that detect the defect and only one was disabled.

Ref: nodejs#5268
Fixes: nodejs#4343
@Trott Trott mentioned this issue Feb 17, 2016
Closed
@Trott Trott closed this as completed in c4b5a45 Feb 19, 2016
rvagg pushed a commit that referenced this issue Feb 21, 2016
@Trott @rvagg
test: mitigate flaky test-debug-no-context
df7d91f 
Change test so that it passes on the occasional win10 access violation.

The workaround here can be undone when issue 5268 is resolved.

The test still detects the defect it was written to detect. There are
two assertions that detect the defect and only one was disabled.

Ref: #5268
Fixes: #4343
PR-URL: #5269
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this issue Mar 1, 2016
@Trott
test: mitigate flaky test-debug-no-context
c66c5d0 
Change test so that it passes on the occasional win10 access violation.

The workaround here can be undone when issue 5268 is resolved.

The test still detects the defect it was written to detect. There are
two assertions that detect the defect and only one was disabled.

Ref: #5268
Fixes: #4343
PR-URL: #5269
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this issue Mar 1, 2016
@Trott
test: mitigate flaky test-debug-no-context
18e3987 
Change test so that it passes on the occasional win10 access violation.

The workaround here can be undone when issue 5268 is resolved.

The test still detects the defect it was written to detect. There are
two assertions that detect the defect and only one was disabled.

Ref: #5268
Fixes: #4343
PR-URL: #5269
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this issue Mar 2, 2016
@Trott
test: mitigate flaky test-debug-no-context
1ed55b8 
Change test so that it passes on the occasional win10 access violation.

The workaround here can be undone when issue 5268 is resolved.

The test still detects the defect it was written to detect. There are
two assertions that detect the defect and only one was disabled.

Ref: #5268
Fixes: #4343
PR-URL: #5269
Reviewed-By: James M Snell <jasnell@gmail.com>
scovetta pushed a commit to scovetta/node that referenced this issue Apr 2, 2016
@Trott
test: mark test-debug-no-context is flaky
b4bdb0a 
test-debug-no-context is flaky on Windows. Mark as such.

Ref: nodejs#4343
PR-URL: nodejs#4421
Reviewed-By: Brian White <mscdex@mscdex.net>
@leonardoadame leonardoadame mentioned this issue Dec 1, 2023
Open
@aliscco aliscco mentioned this issue Dec 2, 2023
Open
@leonardoadame leonardoadame mentioned this issue Feb 11, 2024
Open
@aliscco aliscco mentioned this issue Feb 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arm Issues and PRs related to the ARM platform. test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: mitigate flaky test-debug-no-context Trott/io.js
4 participants
@mscdex @bnoordhuis @MylesBorins @Trott