Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark: run.js output regression after d636fee319bc #43628

Closed
mscdex opened this issue Jun 30, 2022 · 0 comments
Closed

benchmark: run.js output regression after d636fee319bc #43628

mscdex opened this issue Jun 30, 2022 · 0 comments
Labels
benchmark Issues and PRs related to the benchmark subsystem. regression Issues related to regressions.

Comments

@mscdex
Copy link
Contributor

mscdex commented Jun 30, 2022

Version

main

Platform

n/a

Subsystem

benchmark

What steps will reproduce the bug?

./out/Release/node benchmark/run.js --format csv -- assert

How often does it reproduce? Is there a required condition?

Every time

What is the expected behavior?

Output should be in CSV format

What do you see instead?

"Normal" formatted output

Additional information

While d636fee seems to have fixed the truncated results output, it introduced a regression with explicit output formatting (and possibly other settings).

We need to add more tests to cover more of the benchmark runner's features, including output type.

/cc @ShogunPanda
@mscdex mscdex added benchmark Issues and PRs related to the benchmark subsystem. regression Issues related to regressions. labels Jun 30, 2022
mscdex added a commit to mscdex/io.js that referenced this issue Jun 30, 2022
@mscdex
benchmark: fix output regression
6973380 
Fixes: nodejs#43628
@mscdex mscdex mentioned this issue Jun 30, 2022
Closed
targos pushed a commit that referenced this issue Jul 12, 2022
@mscdex @targos
benchmark: fix output regression
7ee0be7 
Fixes: #43628

PR-URL: #43635
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
targos pushed a commit that referenced this issue Jul 20, 2022
@mscdex @targos
benchmark: fix output regression
6269549 
Fixes: #43628

PR-URL: #43635
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
targos pushed a commit that referenced this issue Jul 31, 2022
@mscdex @targos
benchmark: fix output regression
3b10a94 
Fixes: #43628

PR-URL: #43635
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this issue Oct 10, 2022
@mscdex @guangwong
benchmark: fix output regression
e1da0ac 
Fixes: nodejs/node#43628

PR-URL: nodejs/node#43635
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
benchmark Issues and PRs related to the benchmark subsystem. regression Issues related to regressions.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

benchmark: fix output regression mscdex/io.js
1 participant
@mscdex