Node API core consolidation #44071
Labels
node-api
Issues and PRs related to the Node-API.
Comments
This was referenced Aug 4, 2022
|
I am interested in working on this |
|
@deepakrkris it will be great if you can help out on this! As we discussed in the last node-api team meeting, please free feel to drop a comment on the document if you have any questions. |
legendecas
added a commit
that referenced
this issue
Dec 19, 2022
Generalize the finalizer's second pass callback to make it cancellable and simplify the code around the second pass callback. With this change, it is determined that Reference::Finalize or RefBase::Finalize are called once, either from the env's shutdown, or from the env's second pass callback. All existing node-api js tests should pass without a touch. The js_native_api cctest is no longer applicable with this change, just removing it. PR-URL: #44141 Refs: #44071 Reviewed-By: Michael Dawson <midawson@redhat.com>
targos
pushed a commit
that referenced
this issue
Jan 1, 2023
Generalize the finalizer's second pass callback to make it cancellable and simplify the code around the second pass callback. With this change, it is determined that Reference::Finalize or RefBase::Finalize are called once, either from the env's shutdown, or from the env's second pass callback. All existing node-api js tests should pass without a touch. The js_native_api cctest is no longer applicable with this change, just removing it. PR-URL: #44141 Refs: #44071 Reviewed-By: Michael Dawson <midawson@redhat.com>
RafaelGSS
pushed a commit
that referenced
this issue
Jan 4, 2023
Generalize the finalizer's second pass callback to make it cancellable and simplify the code around the second pass callback. With this change, it is determined that Reference::Finalize or RefBase::Finalize are called once, either from the env's shutdown, or from the env's second pass callback. All existing node-api js tests should pass without a touch. The js_native_api cctest is no longer applicable with this change, just removing it. PR-URL: #44141 Refs: #44071 Reviewed-By: Michael Dawson <midawson@redhat.com>
RafaelGSS
pushed a commit
that referenced
this issue
Jan 5, 2023
Generalize the finalizer's second pass callback to make it cancellable and simplify the code around the second pass callback. With this change, it is determined that Reference::Finalize or RefBase::Finalize are called once, either from the env's shutdown, or from the env's second pass callback. All existing node-api js tests should pass without a touch. The js_native_api cctest is no longer applicable with this change, just removing it. PR-URL: #44141 Refs: #44071 Reviewed-By: Michael Dawson <midawson@redhat.com>
juanarbol
pushed a commit
that referenced
this issue
Jan 26, 2023
Generalize the finalizer's second pass callback to make it cancellable and simplify the code around the second pass callback. With this change, it is determined that Reference::Finalize or RefBase::Finalize are called once, either from the env's shutdown, or from the env's second pass callback. All existing node-api js tests should pass without a touch. The js_native_api cctest is no longer applicable with this change, just removing it. PR-URL: #44141 Refs: #44071 Reviewed-By: Michael Dawson <midawson@redhat.com>
|
@legendecas maybe we should go through this in the next node-api meeting to see what's been completed and what is still needed on this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
People are complaining that the node-api core implementation is deviating from node.js core conventions and has a lot of workarounds and non-conventional mechanisms, especially around the finalizers. It makes it harder to maintain the node-api code base.
I'm working with the @nodejs/node-api team on the document https://docs.google.com/document/d/1Bqm05PWQni65FVdSKiaVAkqCAOD9HIfCqG_Y4CAYTbo/edit?usp=sharing to list the problems we are facing and try to figure out what approaches we can apply.
@addaleax thanks for bringing the topic up at #36510 (comment).
Opening this issue to track the progress.
The text was updated successfully, but these errors were encountered: