Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-trivial to build with --ninja on yum-based Linux distros #44286

Closed
timClicks opened this issue Aug 19, 2022 · 1 comment · Fixed by #44293
Closed

Non-trivial to build with --ninja on yum-based Linux distros #44286

timClicks opened this issue Aug 19, 2022 · 1 comment · Fixed by #44293
Labels
build Issues and PRs related to build files or the CI.

Comments

@timClicks
Copy link

timClicks commented Aug 19, 2022 •
edited
Loading

On Linux distros that use the yum package manager, it's cumbersome to build with ninja because you need to remember to create a symlink. yum installs ninja as ninja-build, but this is hard-coded in the Makefile as ninja.

node/Makefile

Line 127 in a2dcc08

ninja -C out/Release $(NINJA_ARGS)

@jdx
Copy link
Contributor

jdx commented Aug 19, 2022

I'm not sure if there is a convention for this (like CC or CXX env vars), but maybe this could be NINJA? Or NINJA_BIN?

@jdx jdx mentioned this issue Aug 19, 2022
Merged
jdx added a commit to jdx/node that referenced this issue Aug 19, 2022
@jdx
build: added NINJA_BIN to customize ninja binary
05449be 
Fixes: nodejs#44286
@daeyeon daeyeon added the build Issues and PRs related to build files or the CI. label Aug 19, 2022
jdx added a commit to jdx/node that referenced this issue Aug 19, 2022
@jdx
build: added NINJA_BIN to customize ninja binary
983ea92 
Fixes: nodejs#44286
jdx added a commit to jdx/node that referenced this issue Aug 19, 2022
@jdx
build: added NINJA env to customize ninja binary
c152f99 
Fixes: nodejs#44286
jdx added a commit to jdx/node that referenced this issue Aug 19, 2022
@jdx
build: added NINJA env to customize ninja binary
0a5c34c 
Fixes: nodejs#44286
nodejs-github-bot pushed a commit that referenced this issue Aug 22, 2022
@jdx
build: added NINJA env to customize ninja binary
fd07bab 
Fixes: #44286
PR-URL: #44293
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
RafaelGSS pushed a commit that referenced this issue Sep 5, 2022
@jdx @RafaelGSS
build: added NINJA env to customize ninja binary
30da2b4 
Fixes: #44286
PR-URL: #44293
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Fyko pushed a commit to Fyko/node that referenced this issue Sep 15, 2022
@jdx @Fyko
build: added NINJA env to customize ninja binary
7fc1502 
Fixes: nodejs#44286
PR-URL: nodejs#44293
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit that referenced this issue Sep 16, 2022
@jdx @targos
build: added NINJA env to customize ninja binary
25c90f2 
Fixes: #44286
PR-URL: #44293
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
juanarbol pushed a commit that referenced this issue Oct 10, 2022
@jdx @juanarbol
build: added NINJA env to customize ninja binary
bfc98e9 
Fixes: #44286
PR-URL: #44293
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
juanarbol pushed a commit that referenced this issue Oct 11, 2022
@jdx @juanarbol
build: added NINJA env to customize ninja binary
2a4491b 
Fixes: #44286
PR-URL: #44293
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this issue Jan 3, 2023
@jdx @guangwong
build: added NINJA env to customize ninja binary
e6c671e 
Fixes: nodejs/node#44286
PR-URL: nodejs/node#44293
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this issue Jan 3, 2023
@jdx @guangwong
build: added NINJA env to customize ninja binary
8e906f8 
Fixes: nodejs/node#44286
PR-URL: nodejs/node#44293
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: added NINJA env to customize ninja binary jdx/node
3 participants
@timClicks @jdx @daeyeon