-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
npm update broke node-addon-api tests on AIX #44548
Comments
From some investigation, it looks to be the update to npm 8.18.0. Using that npm version with an older/newer version of Node.js results in the error. Using 8.15.0 (which was in the previous Node.js version) with a newer or older version of Node.js does not result in the error. |
Looking at what is new in that version of npm I see - npm/cli#5297 which seems to be the cause. Reverting that allows the install to work. |
Setting |
@lux01 can you comment on whether the behaviour we are seeing is what you expected based on the fix for npm/cli#5297 ? The tests used to pass I believe because the node-addon-api job set the shell to bash before doing the install. npm/cli#5297 seems to have caused npm to ingore the current shell by default. I've fixed the node-addon-api test job by setting the script-shell as part of the job, but not sure if that the new behaviour is as expected. |
@mhdawson Sorry my GitHub notifications don't seem to be working for some reason. The setting As it stands See npm/run-script#103 and npm/cli#5489. |
Ok, so onced we get an update to 8.18.0 things will be resolved and even after then the work around I put in place for the node-addon-api test will continue to work so I think we can close this. @lux01 thanks for the info. |
Version
v18.8.0
Platform
AIX
Subsystem
No response
What steps will reproduce the bug?
npm install pre-commit
How often does it reproduce? Is there a required condition?
100%
What is the expected behavior?
package is installed
What do you see instead?
npm ERR! code 127
npm ERR! path /home/iojs/build/workspace/node-test-node-addon-api-new/nodes/aix72-ppc64/node_modules/pre-commit
npm ERR! command failed
npm ERR! command sh -c -- node install.js
npm ERR! node install.js: --: not found
npm ERR! A complete log of this run can be found in:
npm ERR! /home/iojs/build/workspace/citgm-smoker/npm_cache/_logs/2022-09-06T21_20_27_438Z-debug-0.log
iojs@nodejs04:[/home/iojs/build/workspace/node-test-node-addon-api-new/nodes/aix72-ppc64]node-v18.8.0-aix-ppc64/bin/node node-v18.7.0-aix-ppc64/lib/node_modules/npm/bin/npm-cli.js install pre-commit
Additional information
This can out of looking at node-addon-api failures on AIX - like this - https://ci.nodejs.org/job/node-test-node-addon-api-new/nodes=aix72-ppc64/6348/console
pre-commit is one of the packages in the package.json for node-addon-api
The text was updated successfully, but these errors were encountered: