fix: remove the temp file entirely #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlf
force-pushed
the
nlf/remove-temp-file
branch
from
bd8673c
to
3def9af
Compare
wraithgar
approved these changes
Aug 8, 2022
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes npm/cli#5195
the use of the temp file was technically a breaking change for folks using cmd.exe as their script-shell, i.e. our default in windows.
the specific breakage is that when used in a file, you must escape the
%as%%but only when running your script from a file. it's subtle, but this means by default our windows users would have to modify their scripts to ensure the%is escaped. by removing the temp file, we fix this breakage.