Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Regression in 8.13.0 on Windows: echo 5% prints just 5 instead of 5% #5285

Closed
2 tasks done
lydell opened this issue Aug 9, 2022 · 3 comments
Closed
2 tasks done
Labels
Bug thing that needs fixing Needs Triage needs review for next steps Release 8.x work is associated with a specific npm 8 release

Comments

@lydell
Copy link

lydell commented Aug 9, 2022

Is there an existing issue for this?

  • I have searched the existing issues

This issue exists in the latest npm version

  • I am using the latest npm

Current Behavior

$ npm test

> test
> echo 5%

5

This happens since 8.13.0.

Expected Behavior

$ npm test

> test
> echo 5%

5%

8.12.2 prints 5% as expected.

Steps To Reproduce

  1. Use Windows

  2. With this package.json:

    {
      "private": true,
      "scripts": {
        "test": "echo 5%"
      }
    }
  3. Run npm test

  4. Notice how the percentage sign is gone.

Environment

  • npm: 8.16.0
  • Node.js: 18.7.0
  • OS Name: Windows 10
  • System Model Name: PC
@lydell lydell added Bug thing that needs fixing Needs Triage needs review for next steps Release 8.x work is associated with a specific npm 8 release labels Aug 9, 2022
@simplesmiler
Copy link

simplesmiler commented Aug 10, 2022

Can confirm, stumbled upon it with different scenario:

# npx echo-cli Привіт

╨Я╤А╨╕╨▓╤Ц╤В

OS: Windows 10 with English locale.

@nlf
Copy link
Contributor

nlf commented Aug 15, 2022

this should work correctly as of npm@8.17.0, but please do reopen the issue if you can still reproduce it

@nlf nlf closed this as completed Aug 15, 2022
@lydell
Copy link
Author

lydell commented Aug 15, 2022

Amazing!

For the curious following along, this was the fix I think: npm/run-script#98

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug thing that needs fixing Needs Triage needs review for next steps Release 8.x work is associated with a specific npm 8 release
Projects
None yet
Development

No branches or pull requests

3 participants