-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"message.headers" incorrectly shows use of "console.log(request.getHeaders());" as an example. #44567
Comments
lpinca
added a commit
to lpinca/node
that referenced
this issue
Sep 10, 2022
lpinca
added a commit
to lpinca/node
that referenced
this issue
Sep 10, 2022
Fyko
pushed a commit
to Fyko/node
that referenced
this issue
Sep 15, 2022
Fixes: nodejs#44567 PR-URL: nodejs#44587 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Mestery <mestery@protonmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this issue
Jan 3, 2023
Fixes: nodejs/node#44567 PR-URL: nodejs/node#44587 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Mestery <mestery@protonmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this issue
Jan 3, 2023
Fixes: nodejs/node#44567 PR-URL: nodejs/node#44587 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Mestery <mestery@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Affected URL(s)
https://nodejs.org/docs/latest-v16.x/api/http.html#messageheaders
https://nodejs.org/docs/latest-v18.x/api/http.html#messageheaders
Description of the problem
With
req.getHeaders()
, you get an error:with
req.headers
, you don't.However, the example in the docs (both v16 and v18) shows the (non-working) use of:
console.log(request.getHeaders());
..under the sub-section message.headers.
The text was updated successfully, but these errors were encountered: