Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate flaky test-runner-inspect #44600

Closed
tniessen opened this issue Sep 11, 2022 · 2 comments · Fixed by #44620
Closed

Investigate flaky test-runner-inspect #44600

tniessen opened this issue Sep 11, 2022 · 2 comments · Fixed by #44620
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. windows Issues and PRs related to the Windows platform.

Comments

@tniessen
Copy link
Member

tniessen commented Sep 11, 2022 •
edited
Loading

Test

test-runner-inspect

Platform

Windows

Console output

not ok 836 parallel/test-runner-inspect
  ---
  duration_ms: 120.197
  severity: fail
  exitcode: 1
  stack: |-
    timeout
    [test] Connecting to a child Node process
    [test] Testing /json/list
    [err] (node:10532) Warning: Using the inspector with --test forces running at a concurrency of 1. Use the inspectPort option to run with concurrency
    [err] (Use `node --trace-warnings ...` to show where the warning was created)
    [err] 
    [out] TAP version 13
    [out] 
  ...

Build links

Additional information

This test was added yesterday in #44520.
@tniessen tniessen added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Sep 11, 2022
@github-actions github-actions bot added the windows Issues and PRs related to the Windows platform. label Sep 11, 2022
@tniessen tniessen mentioned this issue Sep 11, 2022
Merged
@MoLow
Copy link
Member

MoLow commented Sep 11, 2022

Checking

@MoLow
Copy link
Member

MoLow commented Sep 12, 2022

there is this failure, where it is obvious that the inspector message is printed, but it is not detected by makeStderrCallback as isInspectorMessage, this seems to be the underlaying issue in all of the other cases as well

@MoLow MoLow mentioned this issue Sep 12, 2022
Merged
nodejs-github-bot pushed a commit that referenced this issue Sep 14, 2022
@MoLow
test: fix test-runner-inspect
9825a7e 
PR-URL: #44620
Fixes: #44600
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Fyko pushed a commit to Fyko/node that referenced this issue Sep 15, 2022
@MoLow @Fyko
test: fix test-runner-inspect
4e02568 
PR-URL: nodejs#44620
Fixes: nodejs#44600
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
RafaelGSS pushed a commit that referenced this issue Sep 26, 2022
@MoLow @RafaelGSS
test: fix test-runner-inspect
938751b 
PR-URL: #44620
Fixes: #44600
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
RafaelGSS pushed a commit that referenced this issue Sep 26, 2022
@MoLow @RafaelGSS
test: fix test-runner-inspect
36a4661 
PR-URL: #44620
Fixes: #44600
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
MoLow added a commit to MoLow/node that referenced this issue Sep 29, 2022
@MoLow
test: fix test-runner-inspect
9fbebd2 
PR-URL: nodejs#44620
Fixes: nodejs#44600
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
MoLow added a commit to MoLow/node that referenced this issue Sep 29, 2022
@MoLow
test: fix test-runner-inspect
c743751 
PR-URL: nodejs#44620
Backport-PR-URL: nodejs#44813
Fixes: nodejs#44600
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
MoLow added a commit to MoLow/node that referenced this issue Sep 29, 2022
@MoLow
test: fix test-runner-inspect
37d1e5a 
PR-URL: nodejs#44620
Backport-PR-URL: nodejs#44813
Fixes: nodejs#44600
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
MoLow added a commit to MoLow/node that referenced this issue Oct 2, 2022
@MoLow
test: fix test-runner-inspect
a797681 
PR-URL: nodejs#44620
Backport-PR-URL: nodejs#44813
Fixes: nodejs#44600
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
MoLow added a commit to MoLow/node that referenced this issue Oct 3, 2022
@MoLow
test: fix test-runner-inspect
f44fcd9 
PR-URL: nodejs#44620
Backport-PR-URL: nodejs#44873
Fixes: nodejs#44600
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
MoLow added a commit to MoLow/node that referenced this issue Oct 3, 2022
@MoLow
test: fix test-runner-inspect
d351059 
PR-URL: nodejs#44620
Backport-PR-URL: nodejs#44873
Fixes: nodejs#44600
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
MoLow added a commit to MoLow/node that referenced this issue Oct 3, 2022
@MoLow
test: fix test-runner-inspect
23ab7fe 
PR-URL: nodejs#44620
Backport-PR-URL: nodejs#44873
Fixes: nodejs#44600
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this issue Oct 4, 2022
@MoLow @danielleadams
test: fix test-runner-inspect
56c9c98 
PR-URL: #44620
Backport-PR-URL: #44813
Fixes: #44600
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
MoLow added a commit to MoLow/node that referenced this issue Oct 12, 2022
@MoLow
test: fix test-runner-inspect
7cedf43 
PR-URL: nodejs#44620
Backport-PR-URL: nodejs#44873
Fixes: nodejs#44600
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
MoLow added a commit to MoLow/node that referenced this issue Oct 12, 2022
@MoLow
test: fix test-runner-inspect
fd049ce 
PR-URL: nodejs#44620
Backport-PR-URL: nodejs#44873
Fixes: nodejs#44600
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
MoLow added a commit to MoLow/node that referenced this issue Oct 12, 2022
@MoLow
test: fix test-runner-inspect
cd94db5 
PR-URL: nodejs#44620
Backport-PR-URL: nodejs#44873
Fixes: nodejs#44600
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
MoLow added a commit to MoLow/node that referenced this issue Oct 12, 2022
@MoLow
test: fix test-runner-inspect
6302c3b 
PR-URL: nodejs#44620
Backport-PR-URL: nodejs#44873
Fixes: nodejs#44600
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
MoLow added a commit to MoLow/node that referenced this issue Nov 23, 2022
@MoLow
test: fix test-runner-inspect
c1e8382 
PR-URL: nodejs#44620
Backport-PR-URL: nodejs#44873
Fixes: nodejs#44600
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
MoLow added a commit to MoLow/node that referenced this issue Nov 23, 2022
@MoLow
test: fix test-runner-inspect
68c1975 
PR-URL: nodejs#44620
Backport-PR-URL: nodejs#44873
Fixes: nodejs#44600
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
MoLow added a commit to MoLow/node that referenced this issue Nov 23, 2022
@MoLow
test: fix test-runner-inspect
c9d8f68 
PR-URL: nodejs#44620
Backport-PR-URL: nodejs#44873
Fixes: nodejs#44600
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
MoLow added a commit to MoLow/node that referenced this issue Nov 23, 2022
@MoLow
test: fix test-runner-inspect
3c4c0cd 
PR-URL: nodejs#44620
Backport-PR-URL: nodejs#44873
Fixes: nodejs#44600
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
richardlau pushed a commit that referenced this issue Dec 7, 2022
@MoLow @richardlau
test: fix test-runner-inspect
02a18ea 
PR-URL: #44620
Backport-PR-URL: #44873
Fixes: #44600
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this issue Jan 3, 2023
@MoLow @guangwong
test: fix test-runner-inspect
e34af51 
PR-URL: nodejs/node#44620
Backport-PR-URL: nodejs/node#44873
Fixes: nodejs/node#44600
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this issue Jan 3, 2023
@MoLow @guangwong
test: fix test-runner-inspect
2dcd0bf 
PR-URL: nodejs/node#44620
Backport-PR-URL: nodejs/node#44873
Fixes: nodejs/node#44600
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
MoLow added a commit to MoLow/node-core-test that referenced this issue Feb 2, 2023
@MoLow
test: fix test-runner-inspect
3ae0cf6 
PR-URL: nodejs/node#44620
Fixes: nodejs/node#44600
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
(cherry picked from commit 9825a7e01d35b9d49ebb58efed2c316012c19db6)
MoLow added a commit to MoLow/node-core-test that referenced this issue Feb 2, 2023
@MoLow
test: fix test-runner-inspect
9f095fa 
PR-URL: nodejs/node#44620
Fixes: nodejs/node#44600
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
(cherry picked from commit 9825a7e01d35b9d49ebb58efed2c316012c19db6)
MoLow added a commit to MoLow/node-core-test that referenced this issue Feb 2, 2023
@MoLow
test: fix test-runner-inspect
7626fcc 
PR-URL: nodejs/node#44620
Fixes: nodejs/node#44600
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
(cherry picked from commit 9825a7e01d35b9d49ebb58efed2c316012c19db6)
MoLow added a commit to MoLow/node-core-test that referenced this issue Feb 2, 2023
@MoLow
test: fix test-runner-inspect
1950b38 
PR-URL: nodejs/node#44620
Fixes: nodejs/node#44600
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
(cherry picked from commit 9825a7e01d35b9d49ebb58efed2c316012c19db6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: fix test-runner-inspect MoLow/node
2 participants
@tniessen @MoLow