Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repl Changes to LTS blocked #4472

Closed
MylesBorins opened this issue Dec 30, 2015 · 4 comments
Closed

Repl Changes to LTS blocked #4472

MylesBorins opened this issue Dec 30, 2015 · 4 comments
Labels
lts Issues and PRs related to Long Term Support releases. repl Issues and PRs related to the REPL subsystem.

Comments

@MylesBorins
Copy link
Contributor

The following PRs / Commits all need to land together
#3988 (To be grouped with #4013)

5169311
#4013 (Needs #4215 to fix)

459b106
#4026 (Needs #4215 to fix)

04b1a2f
#4027 (Blocked by #3988

f2e319b
#4100 (blocked by #4026 )

6526ae7
#4118 (blocked by #4100)

46af397
#4215 (Fixed #4013 and #4026)

213ede6

Most of the work on these were done by @cjihrig and @bnoordhuis

I can attempt to backport these in bulk, but it might be better for someone more familiar with the changes to put together a PR against v4.x-staging with all the above commits rebased and working
@MylesBorins
Copy link
Contributor Author

/cc @jasnell

@MylesBorins MylesBorins added repl Issues and PRs related to the REPL subsystem. lts-watch-v4.x lts Issues and PRs related to Long Term Support releases. labels Dec 30, 2015
@bnoordhuis
Copy link
Member

Do they apply cleanly? I would expect them to.

@MylesBorins
Copy link
Contributor Author

MylesBorins commented Jan 7, 2016 via email

@cjihrig cjihrig mentioned this issue Jan 7, 2016
Merged
@MylesBorins
Copy link
Contributor Author

Fixed by #4572

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lts Issues and PRs related to Long Term Support releases. repl Issues and PRs related to the REPL subsystem.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bnoordhuis @MylesBorins