Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util: determine object types in C++ #4100

Merged
merged 0 commits into from
Dec 2, 2015
Merged

util: determine object types in C++ #4100

merged 0 commits into from
Dec 2, 2015

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Dec 1, 2015

Determine object types of regular expressions, Dates, Maps, and Sets in the C++ layer instead of depending on toString() behavior in JavaScript.

@evanlucas
Copy link
Contributor

LGTM if CI is happy

@cjihrig
Copy link
Contributor Author

cjihrig commented Dec 1, 2015

CI: https://ci.nodejs.org/job/node-test-pull-request/892/

@cjihrig
Copy link
Contributor Author

cjihrig commented Dec 1, 2015

CI looks good. Some Windows failures of flakey tests. Will land tomorrow.

@targos
Copy link
Member

targos commented Dec 1, 2015

LGTM

@mscdex mscdex added the util Issues and PRs related to the built-in util module. label Dec 1, 2015
@bnoordhuis
Copy link
Member

LGTM. You could maybe DRY it a little using x-macros but that's not strictly necessary and can be done in another PR.

@cjihrig cjihrig closed this Dec 2, 2015
cjihrig added a commit to cjihrig/node that referenced this pull request Dec 2, 2015
@cjihrig
util: determine object types in C++
6526ae7 
Determine object types of regular expressions, Dates, Maps, and
Sets in the C++ layer instead of depending on toString()
behavior in JavaScript.

PR-URL: nodejs#4100
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@cjihrig cjihrig merged commit 6526ae7 into nodejs:master Dec 2, 2015
@cjihrig cjihrig deleted the istype branch December 2, 2015 16:16
@jasnell
Copy link
Member

jasnell commented Dec 2, 2015

While not strictly necessary, I think marking this one for LTS would make sense.

@cjihrig cjihrig mentioned this pull request Dec 2, 2015
Merged
cjihrig added a commit to cjihrig/node that referenced this pull request Dec 4, 2015
@cjihrig
src: define Is* util functions with macros
46af397 
The Is* type checking functions in node_util.cc are mostly
the same boilerplate. This commit defines them using a macro.

Refs: nodejs#4100
PR-URL: nodejs#4118
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
cjihrig added a commit that referenced this pull request Dec 5, 2015
@cjihrig @rvagg
util: determine object types in C++
1b434e0 
Determine object types of regular expressions, Dates, Maps, and
Sets in the C++ layer instead of depending on toString()
behavior in JavaScript.

PR-URL: #4100
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
cjihrig added a commit that referenced this pull request Dec 5, 2015
@cjihrig @rvagg
src: define Is* util functions with macros
d969c09 
The Is* type checking functions in node_util.cc are mostly
the same boilerplate. This commit defines them using a macro.

Refs: #4100
PR-URL: #4118
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Dec 8, 2015
Closed
Merged
@rvagg rvagg mentioned this pull request Dec 17, 2015
Closed
@MylesBorins
Copy link
Contributor

This relies on #4026 to land

@MylesBorins MylesBorins mentioned this pull request Dec 30, 2015
Closed
cjihrig added a commit to cjihrig/node that referenced this pull request Jan 7, 2016
@cjihrig
util: determine object types in C++
b5f8a35 
Determine object types of regular expressions, Dates, Maps, and
Sets in the C++ layer instead of depending on toString()
behavior in JavaScript.

PR-URL: nodejs#4100
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
cjihrig added a commit to cjihrig/node that referenced this pull request Jan 7, 2016
@cjihrig
src: define Is* util functions with macros
1782577 
The Is* type checking functions in node_util.cc are mostly
the same boilerplate. This commit defines them using a macro.

Refs: nodejs#4100
PR-URL: nodejs#4118
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>

Conflicts:
	src/node_util.cc
MylesBorins pushed a commit that referenced this pull request Jan 19, 2016
@cjihrig
util: determine object types in C++
b421119 
Determine object types of regular expressions, Dates, Maps, and
Sets in the C++ layer instead of depending on toString()
behavior in JavaScript.

PR-URL: #4100
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
MylesBorins pushed a commit that referenced this pull request Jan 19, 2016
@cjihrig
src: define Is* util functions with macros
3080bdc 
The Is* type checking functions in node_util.cc are mostly
the same boilerplate. This commit defines them using a macro.

Refs: #4100
PR-URL: #4118
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>

Conflicts:
	src/node_util.cc
@MylesBorins MylesBorins mentioned this pull request Jan 19, 2016
Merged
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
@cjihrig
util: determine object types in C++
4db096d 
Determine object types of regular expressions, Dates, Maps, and
Sets in the C++ layer instead of depending on toString()
behavior in JavaScript.

PR-URL: nodejs#4100
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
@cjihrig
src: define Is* util functions with macros
9e201ae 
The Is* type checking functions in node_util.cc are mostly
the same boilerplate. This commit defines them using a macro.

Refs: nodejs#4100
PR-URL: nodejs#4118
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins
Copy link
Contributor

@jdalton experiencing issues with this?

@jdalton
Copy link
Member

jdalton commented Jun 2, 2016 •
edited
Loading

Nope. Just cc'ing folks in (@arv and @bmeurer) that were interested.
I ❤️ the additions. They're ~2x or more faster than my vanilla JS implementations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@cjihrig @evanlucas @targos @bnoordhuis @jasnell @MylesBorins @jdalton @mscdex