Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question: openssl 1.1.1 supported in 18.x? #44722

Closed
AdamMajer opened this issue Sep 19, 2022 · 0 comments · Fixed by #44725
Closed

Question: openssl 1.1.1 supported in 18.x? #44722

AdamMajer opened this issue Sep 19, 2022 · 0 comments · Fixed by #44725
Labels
openssl Issues and PRs related to the OpenSSL dependency. question Issues that look for answers.

Comments

@AdamMajer
Copy link
Contributor

AdamMajer commented Sep 19, 2022 •
edited by VoltrexKeyva
Loading

Version

18.9.0

Platform

No response

Subsystem

external openssl

What steps will reproduce the bug?

Build with external OpenSSL 1.1.1

How often does it reproduce? Is there a required condition?

No response

What is the expected behavior?

No response

What do you see instead?

[  168s]     '../binding.cc:3:10: fatal error: openssl/provider.h: No such file or directory\n' +
[  168s]     '    3 | #include <openssl/provider.h>\n' +

Additional information

Question: Will Node 18.x support external OpenSSL 1.1.1 or will it require OpenSSL 3.x?
@VoltrexKeyva VoltrexKeyva added question Issues that look for answers. openssl Issues and PRs related to the OpenSSL dependency. labels Sep 19, 2022
AdamMajer added a commit to AdamMajer/node that referenced this issue Sep 19, 2022
@AdamMajer
test: fix addon tests compilation with OpenSSL 1.1.1
c9419bf 
openssl/provider.h header is not part of OpenSSL 1.1.1 so do not
include it when building with an older instance.

Fixes: nodejs#44722
@RaisinTen RaisinTen mentioned this issue Sep 20, 2022
Merged
nodejs-github-bot pushed a commit that referenced this issue Sep 22, 2022
@AdamMajer
test: fix addon tests compilation with OpenSSL 1.1.1
4565918 
openssl/provider.h header is not part of OpenSSL 1.1.1 so do not
include it when building with an older instance.

Fixes: #44722
PR-URL: #44725
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
RafaelGSS pushed a commit that referenced this issue Sep 26, 2022
@AdamMajer @RafaelGSS
test: fix addon tests compilation with OpenSSL 1.1.1
8acb425 
openssl/provider.h header is not part of OpenSSL 1.1.1 so do not
include it when building with an older instance.

Fixes: #44722
PR-URL: #44725
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
RafaelGSS pushed a commit that referenced this issue Sep 26, 2022
@AdamMajer @RafaelGSS
test: fix addon tests compilation with OpenSSL 1.1.1
54cd2f4 
openssl/provider.h header is not part of OpenSSL 1.1.1 so do not
include it when building with an older instance.

Fixes: #44722
PR-URL: #44725
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
RafaelGSS pushed a commit that referenced this issue Sep 26, 2022
@AdamMajer @RafaelGSS
test: fix addon tests compilation with OpenSSL 1.1.1
a56cb65 
openssl/provider.h header is not part of OpenSSL 1.1.1 so do not
include it when building with an older instance.

Fixes: #44722
PR-URL: #44725
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
openssl Issues and PRs related to the OpenSSL dependency. question Issues that look for answers.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: fix addon tests compilation with OpenSSL 1.1.1 AdamMajer/node
2 participants
@AdamMajer @VoltrexKeyva