-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate flaky test.parallel/test-fs-watch-recursive #45535
Labels
flaky-test
Issues and PRs related to the tests with unstable failures on the CI.
Comments
anonrig
added
the
flaky-test
Issues and PRs related to the tests with unstable failures on the CI.
label
Nov 20, 2022
Could we mark it as flaky since it is causing many CI red |
It's failing a lot on different operating systems lately. The non-recursive version acted up in the past too, see #40728. The file is really a bunch of different tests packed together. I want to suggest splitting them into separate files and marking them flaky individually. |
cheungxi
pushed a commit
to cheungxi/node
that referenced
this issue
Feb 1, 2023
PR-URL: nodejs#45865 Fixes: nodejs#45535 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Test
test.parallel/test-fs-watch-recursive
Platform
No response
Console output
Timeout
Build links
Linux:
macOS:
Additional information
No response
The text was updated successfully, but these errors were encountered: