-
Notifications
You must be signed in to change notification settings - Fork 28.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CryptoKey string tag imprecise for detection #45987
Comments
…webcrypto detectionn isn't working due to nodejs/node#45987
Pull request welcome, but... We do WPT conformance testing so this is probably not a spec requirement. It'd be best to update upstream WPT first before making changes to node. There's a CryptoKey validator you could add a check to. |
Thanks for the info. IIRC, there are some separate WebIDL-based tests in WPT which might cover class string (string tag) checks for interfaces (and these tests weren't always contained in the same part of the directory structure). As far as a spec basis for this, there is some mention of class strings in https://webidl.spec.whatwg.org/ , though I only see it mentioned there for interface prototypes, not necessarily interface objects. I wonder if it is implied elsewhere within WebIDL though. |
I am not sure about this being a spec requirement too but if all existing implementations adhere, I don't see the point of not adding this to Node.js and WPT. PR for the WPT repository web-platform-tests/wpt#37716. |
…webcrypto detection isn't working due to nodejs/node#45987
…webcrypto detection isn't working due to nodejs/node#45987
feat: use built-in webcrypto and update for latest Node
feat: use built-in webcrypto and update for latest Node
…e#45987 feat: use built-in webcrypto and update for latest Node
closes nodejs#45987 PR-URL: nodejs#46042 Fixes: nodejs#45987 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
closes nodejs#45987 PR-URL: nodejs#46042 Fixes: nodejs#45987 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Backport-PR-URL: nodejs#46340
closes nodejs#45987 PR-URL: nodejs#46042 Fixes: nodejs#45987 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Backport-PR-URL: nodejs#46340
closes nodejs#45987 PR-URL: nodejs#46042 Backport-PR-URL: nodejs#46340 Fixes: nodejs#45987 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
closes nodejs#45987 PR-URL: nodejs#46042 Fixes: nodejs#45987 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Backport-PR-URL: nodejs#47336
closes nodejs#45987 PR-URL: nodejs#46042 Fixes: nodejs#45987 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Backport-PR-URL: nodejs#47336
Version
v18.12.1
Platform
Darwin MacBook-Air-2.local 22.2.0 Darwin Kernel Version 22.2.0: Fri Nov 11 02:04:44 PST 2022; root:xnu-8792.61.2~4/RELEASE_ARM64_T8103 arm64
Subsystem
No response
What steps will reproduce the bug?
How often does it reproduce? Is there a required condition?
Always
What is the expected behavior?
On the browser, this logs
CryptoKey
and allows for detection of object type and we expect it here.What do you see instead?
Object
Additional information
This can be readily remedied by adding Symbol.toStringTag to the CryptoKey class returning the value, "CryptoKey".
The text was updated successfully, but these errors were encountered: