-
Notifications
You must be signed in to change notification settings - Fork 30.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test-http-header-overflow has passed only if socket buffer is more than 16Kb #46291
Labels
flaky-test
Issues and PRs related to the tests with unstable failures on the CI.
linux
Issues and PRs related to the Linux platform.
Comments
lpinca
added a commit
to lpinca/node
that referenced
this issue
Sep 17, 2024
Skip the network and push the data directly to the receiving socket so that it is guaranteed to be received as a single chunk. Fixes: nodejs#46291
louwers
pushed a commit
to louwers/node
that referenced
this issue
Nov 2, 2024
Skip the network and push the data directly to the receiving socket so that it is guaranteed to be received as a single chunk. Fixes: nodejs#46291 PR-URL: nodejs#54978 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: James M Snell <jasnell@gmail.com>
tpoisseau
pushed a commit
to tpoisseau/node
that referenced
this issue
Nov 21, 2024
Skip the network and push the data directly to the receiving socket so that it is guaranteed to be received as a single chunk. Fixes: nodejs#46291 PR-URL: nodejs#54978 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
flaky-test
Issues and PRs related to the tests with unstable failures on the CI.
linux
Issues and PRs related to the Linux platform.
Test
test-http-header-overflow
Platform
Linux x64
Console output
No response
Build links
Additional information
If socket buffer is less or equal than 16Kb then overflowed HTTP header (its size >16Kb) has two chunks: the first one is read from the socket and all is good, but after second chunk reading we have throw error (we wait this error) with data buffer only from second chunk. But we try to validate not only the error code, but also whole data buffer with overflowed HTTP header. But current error object has not whole data buffer, it has only second chunk from posix read() and test is fail.
The most simple way to fix - don't check data (bytesParsed and rawPacket) at error, check only name, message and code. But perhaps there is more complex way to solve this problem.
The text was updated successfully, but these errors were encountered: