Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nominating @deokjinkim as a collaborator #46329

Closed
aduh95 opened this issue Jan 24, 2023 · 3 comments
Closed

Nominating @deokjinkim as a collaborator #46329

aduh95 opened this issue Jan 24, 2023 · 3 comments
Labels
meta Issues and PRs related to the general management of the project.

Comments

@aduh95
Copy link
Contributor

aduh95 commented Jan 24, 2023

I would like to nominate Deokjin Kim (@deokjinkim) as a collaborator. They have been quite active recently in various areas of the codebase.

Here is a summary of their contributions:

Commits authored on nodejs/node: https://github.com/nodejs/node/commits?author=deokjinkim
Pull requests opened: https://github.com/search?q=author%3Adeokjinkim+org%3Anodejs&type=pullrequests
Issues opened: https://github.com/search?q=author%3Adeokjinkim+org%3Anodejs&type=issues
Reviews on pull requests in nodejs/node: https://github.com/nodejs/node/pulls?q=reviewed-by:deokjinkim
Comments on pull requests and issues throughout the Node.js organization: https://github.com/search?q=commenter%3Adeokjinkim+org%3Anodejs&type=pullrequests

/cc @nodejs/collaborators
@deokjinkim
Copy link
Contributor

It's a great honor for me. Thank you for the nomination!

@VoltrexKeyva VoltrexKeyva added the meta Issues and PRs related to the general management of the project. label Jan 24, 2023
@benjamingr
Copy link
Member

+1 they have demonstrated responsibility, communication and understanding of subsystems and would make a good addition to the project.

@daeyeon
Copy link
Member

daeyeon commented Jan 25, 2023

Welcome! @deokjinkim

deokjinkim added a commit to deokjinkim/node that referenced this issue Jan 31, 2023
@deokjinkim
doc: add deokjinkim to collaborators
9294e43 
Fixes: nodejs#46329
@deokjinkim deokjinkim mentioned this issue Jan 31, 2023
Closed
MylesBorins pushed a commit that referenced this issue Feb 18, 2023
@deokjinkim @MylesBorins
doc: add deokjinkim to collaborators
0c2c322 
Fixes: #46329
PR-URL: #46444
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: theanarkh <theratliter@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this issue Apr 11, 2023
@deokjinkim @danielleadams
doc: add deokjinkim to collaborators
4d5d6d2 
Fixes: #46329
PR-URL: #46444
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: theanarkh <theratliter@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: add deokjinkim to collaborators deokjinkim/node
5 participants
@benjamingr @deokjinkim @daeyeon @aduh95 @VoltrexKeyva