Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky Test parallel/test-http-remove-connection-header-persists-connection #47200

Closed
debadree25 opened this issue Mar 21, 2023 · 2 comments · Fixed by #55959
Closed

Flaky Test parallel/test-http-remove-connection-header-persists-connection #47200

debadree25 opened this issue Mar 21, 2023 · 2 comments · Fixed by #55959
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. macos Issues and PRs related to the macOS platform / OSX.

Comments

@debadree25
Copy link
Member

Test

parallel/test-http-remove-connection-header-persists-connection

Platform

macOS x64

Console output

=== release test-http-remove-connection-header-persists-connection ===        
Path: parallel/test-http-remove-connection-header-persists-connection
node:assert:125
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:

false !== true

    at /Users/debadreechatterjee/Documents/Personal/node/test/parallel/test-http-remove-connection-header-persists-connection.js:67:16
    at Timeout._onTimeout (/Users/debadreechatterjee/Documents/Personal/node/test/parallel/test-http-remove-connection-header-persists-connection.js:54:7)
    at listOnTimeout (node:internal/timers:573:17)
    at process.processTimers (node:internal/timers:514:7) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: false,
  expected: true,
  operator: 'strictEqual'
}

Node.js v20.0.0-pre

Build links

Additional information

This easily reproducible locally on a intel mac by python3 tools/test.py parallel/test-http-remove-connection-header-persists-connection -j10 --repeat 1000

@debadree25 debadree25 added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Mar 21, 2023
@github-actions github-actions bot added the macos Issues and PRs related to the macOS platform / OSX. label Mar 21, 2023
@lpinca
Copy link
Member

lpinca commented Jun 23, 2023

I think this can be closed as per #47316 (comment).

@debadree25
Copy link
Member Author

Hmm yes looks like it @lpinca
closing this, thanks for checking out!

FliegendeWurst added a commit to FliegendeWurst/node that referenced this issue Nov 22, 2024
FliegendeWurst added a commit to FliegendeWurst/node that referenced this issue Nov 23, 2024
FliegendeWurst added a commit to FliegendeWurst/node that referenced this issue Nov 23, 2024
Fixes: nodejs#47200

Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
FliegendeWurst added a commit to FliegendeWurst/node that referenced this issue Nov 23, 2024
Fixes: nodejs#47200

Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
FliegendeWurst added a commit to FliegendeWurst/node that referenced this issue Nov 23, 2024
Fixes: nodejs#47200

Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
FliegendeWurst added a commit to FliegendeWurst/node that referenced this issue Nov 23, 2024
Fixes: nodejs#47200

Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
nodejs-github-bot pushed a commit that referenced this issue Nov 24, 2024
Fixes: #47200

Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #55959
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jason Zhang <xzha4350@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this issue Nov 26, 2024
Fixes: nodejs#47200

Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
PR-URL: nodejs#55959
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jason Zhang <xzha4350@gmail.com>
aduh95 pushed a commit that referenced this issue Nov 26, 2024
Fixes: #47200

Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #55959
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jason Zhang <xzha4350@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. macos Issues and PRs related to the macOS platform / OSX.
Projects
None yet
2 participants