Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updade Node-API version matrix #48277

Closed
gabrielschulhof opened this issue Jun 1, 2023 · 2 comments
Closed

Updade Node-API version matrix #48277

gabrielschulhof opened this issue Jun 1, 2023 · 2 comments
Labels
doc Issues and PRs related to the documentations. node-api Issues and PRs related to the Node-API.

Comments

@gabrielschulhof
Copy link
Contributor

Version

main

Platform

all

Subsystem

node-api

What steps will reproduce the bug?

After we release and backport Version 9, we should update the support matrix with the Node.js versions that provide it, and we should also correct the document to say that opting into versions > 8 requires the presence of #define NAPI_VERSION n where n is the version > 8 required.

How often does it reproduce? Is there a required condition?

100%

What is the expected behavior? Why is that the expected behavior?

Doc is correct.

What do you see instead?

See recommended changes above.

Additional information

No response
@gabrielschulhof gabrielschulhof added doc Issues and PRs related to the documentations. node-api Issues and PRs related to the Node-API. labels Jun 1, 2023
@legendecas legendecas mentioned this issue Jun 2, 2023
Merged
@gabrielschulhof gabrielschulhof changed the title Upade Node-API version matrix Updade Node-API version matrix Jun 16, 2023
@mhdawson mhdawson mentioned this issue Jul 14, 2023
Merged
mhdawson added a commit to mhdawson/io.js that referenced this issue Jul 14, 2023
@mhdawson
doc: refactor node-api support matrix
4c4f0a1 
- refactor table so that it does not grow for
  every new version of Node.js
- refer to latest version of table as the canonical
  reference
- add info for Node-API v9

Refs: nodejs#48277

Signed-off-by: Michael Dawson <mdawson@devrus.com>
@mhdawson
Copy link
Member

PR to address - #48774. Also refactored the table so that it takes less space needs fewer updates.

nodejs-github-bot pushed a commit that referenced this issue Jul 19, 2023
@mhdawson
doc: refactor node-api support matrix
38cc538 
- refactor table so that it does not grow for
  every new version of Node.js
- refer to latest version of table as the canonical
  reference
- add info for Node-API v9

Refs: #48277

Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: #48774
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@mhdawson
Copy link
Member

matrix is updated, closing

pluris pushed a commit to pluris/node that referenced this issue Aug 6, 2023
@mhdawson
doc: refactor node-api support matrix
f867f59 
- refactor table so that it does not grow for
  every new version of Node.js
- refer to latest version of table as the canonical
  reference
- add info for Node-API v9

Refs: nodejs#48277

Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: nodejs#48774
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
pluris pushed a commit to pluris/node that referenced this issue Aug 7, 2023
@mhdawson
doc: refactor node-api support matrix
c08ba57 
- refactor table so that it does not grow for
  every new version of Node.js
- refer to latest version of table as the canonical
  reference
- add info for Node-API v9

Refs: nodejs#48277

Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: nodejs#48774
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this issue Aug 14, 2023
@mhdawson @Ceres6
doc: refactor node-api support matrix
96870a5 
- refactor table so that it does not grow for
  every new version of Node.js
- refer to latest version of table as the canonical
  reference
- add info for Node-API v9

Refs: nodejs#48277

Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: nodejs#48774
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this issue Aug 14, 2023
@mhdawson @Ceres6
doc: refactor node-api support matrix
10b7541 
- refactor table so that it does not grow for
  every new version of Node.js
- refer to latest version of table as the canonical
  reference
- add info for Node-API v9

Refs: nodejs#48277

Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: nodejs#48774
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
UlisesGascon pushed a commit to UlisesGascon/node that referenced this issue Aug 14, 2023
@mhdawson @UlisesGascon
doc: refactor node-api support matrix
19c358d 
- refactor table so that it does not grow for
  every new version of Node.js
- refer to latest version of table as the canonical
  reference
- add info for Node-API v9

Refs: nodejs#48277

Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: nodejs#48774
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit that referenced this issue Aug 15, 2023
@mhdawson @RafaelGSS
doc: refactor node-api support matrix
aeac327 
- refactor table so that it does not grow for
  every new version of Node.js
- refer to latest version of table as the canonical
  reference
- add info for Node-API v9

Refs: #48277

Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: #48774
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this issue Nov 27, 2023
@mhdawson @targos
doc: refactor node-api support matrix
d4fe00d 
- refactor table so that it does not grow for
  every new version of Node.js
- refer to latest version of table as the canonical
  reference
- add info for Node-API v9

Refs: #48277

Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: #48774
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
sercher added a commit to sercher/graaljs that referenced this issue Apr 25, 2024
@sercher
doc: refactor node-api support matrix
382307d 
- refactor table so that it does not grow for
  every new version of Node.js
- refer to latest version of table as the canonical
  reference
- add info for Node-API v9

Refs: nodejs/node#48277

Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: nodejs/node#48774
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
sercher added a commit to sercher/graaljs that referenced this issue Apr 25, 2024
@sercher
doc: refactor node-api support matrix
5890474 
- refactor table so that it does not grow for
  every new version of Node.js
- refer to latest version of table as the canonical
  reference
- add info for Node-API v9

Refs: nodejs/node#48277

Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: nodejs/node#48774
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. node-api Issues and PRs related to the Node-API.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gabrielschulhof @mhdawson