Symbol.{ dispose, asyncDispose } have incorrect descriptors

[zloirock]

Version

20.4.0

Platform

All

Subsystem

No response

What steps will reproduce the bug?

`Object.getOwnPropertyDescriptor(Symbol, 'dispose');

How often does it reproduce? Is there a required condition?

No response

What is the expected behavior? Why is that the expected behavior?

Object.getOwnPropertyDescriptor(Symbol, 'dispose'); // => {value: Symbol(Symbol.dispose), writable: false, enumerable: false, configurable: false}

All well-known symbols should be non-writable, non-enumerable, and non-configurable to avoid patching and breaking things.

What do you see instead?

Object.getOwnPropertyDescriptor(Symbol, 'dispose'); // => {value: Symbol(Symbol.dispose), writable: true, enumerable: true, configurable: true}

Additional information

No response

[zloirock]

tc39/proposal-explicit-resource-management#185

[MoLow]

this is a polyfill until V8 implements explicit resource management, but perhaps we can solve this until than

[ljharb]

@MoLow it's not actually a polyfill if it doesn't match the spec :-p fixing the descriptors should be trivial, so i filed #48703 for that.

Fixing it so that Symbol.keyFor(Symbol.dispose) === undefined and Symbol.for('Symbol(Symbol.dispose)') !== Symbol.dispose is unfortunately trickier :-/

[benjamingr]

@ljharb your fix looks good, open a PR?

[benjamingr]

oh I just saw #48703 nvm :D