We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
https://nodejs.org/api/n-api.html#usage
Shouldn't return NULL be moved outside of the if block in the NAPI_CALL macro? Like this:
return NULL
if (!is_pending) { \ ... \ napi_throw_error((env), NULL, message); \ /* return NULL; */ \ } \ return NULL; \
Otherwise the user's function will continue and may result in more napi calls.
The text was updated successfully, but these errors were encountered:
cc @nodejs/node-api
Sorry, something went wrong.
Thanks for raising the issue. I believe you are right on this that the return statement is misplaced.
Successfully merging a pull request may close this issue.
Affected URL(s)
https://nodejs.org/api/n-api.html#usage
Description of the problem
Shouldn't
return NULL
be moved outside of the if block in the NAPI_CALL macro? Like this:Otherwise the user's function will continue and may result in more napi calls.
The text was updated successfully, but these errors were encountered: