-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experimental coverage skips .ts files #49398
Comments
Why would you expect that to work? Node doesn't handle .ts files. You're probably thinking of ts-node but that's a different project. |
Because --test works. |
No reason for it not to work. The only issue is the code isn't mapped correctly to the source since there is no source maps but that shouldn't prevent reporting statistics. |
PR-URL: nodejs#49406 Fixes: nodejs#49398 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: nodejs/node#49406 Fixes: nodejs/node#49398 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: nodejs/node#49406 Fixes: nodejs/node#49398 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Version
v18.17.1
Platform
Darwin mars.local 23.0.0 Darwin Kernel Version 23.0.0: Fri Aug 18 00:02:20 PDT 2023; root:xnu-10002.1.11~5/RELEASE_ARM64_T8103 arm64
Subsystem
No response
What steps will reproduce the bug?
Pointing to ts files
NODE_V8_COVERAGE=./coverage node -r ts-node/register --test --experimental-test-coverage src/**/*.spec.ts
No coverage is reported
How often does it reproduce? Is there a required condition?
Always
Pointing to js files creates a coverage folder
NODE_V8_COVERAGE=./coverage node -r ts-node/register --test --experimental-test-coverage src/**/*.spec.js
What is the expected behavior? Why is that the expected behavior?
To have coverage
What do you see instead?
Seems coverage reporter is filtering out files that don't have extension
Additional information
No response
The text was updated successfully, but these errors were encountered: