Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change all documentation code examples to CJS when clicking on CJS for one #49508

Closed
eldoy opened this issue Sep 6, 2023 · 2 comments · Fixed by #49526
Closed

Change all documentation code examples to CJS when clicking on CJS for one #49508

eldoy opened this issue Sep 6, 2023 · 2 comments · Fixed by #49526
Labels
doc Issues and PRs related to the documentations.

Comments

@eldoy
Copy link
Contributor

eldoy commented Sep 6, 2023

Affected URL(s)

https://nodejs.org/api/url.html

Description of the problem

When I click on CJS for the first code example of a page in the documentation, the later code examples are still ESM, forcing me to click on the slider for every single example. That is annoying. It would also be nice if my choice could be remembered so I never have to think about that again.
@eldoy eldoy added the doc Issues and PRs related to the documentations. label Sep 6, 2023
@aduh95
Copy link
Contributor

aduh95 commented Sep 6, 2023

Do you want to send a PR?

@eldoy
Copy link
Contributor Author

eldoy commented Sep 6, 2023

@aduh95 OK, will look into it.

eldoy added a commit to eldoy/node that referenced this issue Sep 7, 2023
@eldoy
doc: toggle all flavor selectors sticky on click
bcb1e61 
Fixes: nodejs#49508
@eldoy eldoy mentioned this issue Sep 7, 2023
Merged
aduh95 pushed a commit that referenced this issue Sep 9, 2023
@eldoy
doc: save user preference for JS flavor
b500037 
PR-URL: #49526
Fixes: #49508
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
ruyadorno pushed a commit that referenced this issue Sep 28, 2023
@eldoy @ruyadorno
doc: save user preference for JS flavor
53fb5ae 
PR-URL: #49526
Fixes: #49508
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
alexfernandez pushed a commit to alexfernandez/node that referenced this issue Nov 1, 2023
@eldoy @alexfernandez
doc: save user preference for JS flavor
1fb730a 
PR-URL: nodejs#49526
Fixes: nodejs#49508
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: toggle all flavor selectors sticky on click eldoy/node
2 participants
@eldoy @aduh95