Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement URL.parse() #52208

Closed
annevk opened this issue Mar 25, 2024 · 3 comments · Fixed by #52280
Closed

Implement URL.parse() #52208

annevk opened this issue Mar 25, 2024 · 3 comments · Fixed by #52280
Labels
good first issue Issues that are suitable for first-time contributors. help wanted Issues that need assistance from volunteers or PRs that need help to proceed. whatwg-url Issues and PRs related to the WHATWG URL implementation.

Comments

@annevk
Copy link

annevk commented Mar 25, 2024

See whatwg/url#825 for context.
@annevk annevk mentioned this issue Mar 25, 2024
Merged
5 tasks
@lemire
Copy link
Member

lemire commented Mar 25, 2024

So the idea is essentially that you'd do like new URL(a,b) but URL.parse(a,b) would just not throw unlike new URL... correct?

@anonrig

@mertcanaltin
Copy link
Member

mertcanaltin commented Mar 27, 2024 •
edited
Loading

I'm sorry, I saw it wrong.

@mertcanaltin mertcanaltin reopened this Mar 27, 2024
@anonrig anonrig added good first issue Issues that are suitable for first-time contributors. whatwg-url Issues and PRs related to the WHATWG URL implementation. help wanted Issues that need assistance from volunteers or PRs that need help to proceed. labels Mar 30, 2024
@thisalihassan
Copy link
Contributor

I will raise a PR for this

thisalihassan added a commit to thisalihassan/node that referenced this issue Mar 30, 2024
@thisalihassan
url: implement parse method for safer URL parsing
808a77b 
Implement the static parse method as per the WHATWG URL specification.
Unlike the URL constructor, URL.parse does not throw on invalid input,
instead returning null. This behavior allows safer parsing of URLs
without the need for try-catch blocks around constructor calls. The
implementation follows the steps outlined in the WHATWG URL standard,
ensuring compatibility and consistency with web platform URL parsing
APIs.

Fixes: nodejs#52208
Refs: whatwg/url#825
@thisalihassan thisalihassan mentioned this issue Mar 30, 2024
Merged
nodejs-github-bot pushed a commit that referenced this issue Apr 13, 2024
@thisalihassan
url: implement parse method for safer URL parsing
8b4c4e8 
Implement the static parse method as per the WHATWG URL specification.
Unlike the URL constructor, URL.parse does not throw on invalid input,
instead returning null. This behavior allows safer parsing of URLs
without the need for try-catch blocks around constructor calls. The
implementation follows the steps outlined in the WHATWG URL standard,
ensuring compatibility and consistency with web platform URL parsing
APIs.

Fixes: #52208
Refs: whatwg/url#825
PR-URL: #52280
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Daniel Lemire <daniel@lemire.me>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
aduh95 pushed a commit that referenced this issue Apr 29, 2024
@thisalihassan @aduh95
url: implement parse method for safer URL parsing
9b18df9 
Implement the static parse method as per the WHATWG URL specification.
Unlike the URL constructor, URL.parse does not throw on invalid input,
instead returning null. This behavior allows safer parsing of URLs
without the need for try-catch blocks around constructor calls. The
implementation follows the steps outlined in the WHATWG URL standard,
ensuring compatibility and consistency with web platform URL parsing
APIs.

Fixes: #52208
Refs: whatwg/url#825
PR-URL: #52280
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Daniel Lemire <daniel@lemire.me>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
targos pushed a commit that referenced this issue Sep 21, 2024
@thisalihassan @targos
url: implement parse method for safer URL parsing
4eb0749 
Implement the static parse method as per the WHATWG URL specification.
Unlike the URL constructor, URL.parse does not throw on invalid input,
instead returning null. This behavior allows safer parsing of URLs
without the need for try-catch blocks around constructor calls. The
implementation follows the steps outlined in the WHATWG URL standard,
ensuring compatibility and consistency with web platform URL parsing
APIs.

Fixes: #52208
Refs: whatwg/url#825
PR-URL: #52280
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Daniel Lemire <daniel@lemire.me>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Issues that are suitable for first-time contributors. help wanted Issues that need assistance from volunteers or PRs that need help to proceed. whatwg-url Issues and PRs related to the WHATWG URL implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

url: implement parse method for safer URL parsing thisalihassan/node
5 participants
@lemire @annevk @anonrig @thisalihassan @mertcanaltin