Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minimatch dep update fails #52520

Closed
targos opened this issue Apr 14, 2024 · 2 comments · Fixed by #52523
Closed

Minimatch dep update fails #52520

targos opened this issue Apr 14, 2024 · 2 comments · Fixed by #52523
Labels
dependencies Pull requests that update a dependency file.

Comments

@targos
Copy link
Member

targos commented Apr 14, 2024

https://github.com/nodejs/node/actions/runs/8677247552/job/23792652482
@targos targos added the dependencies Pull requests that update a dependency file. label Apr 14, 2024
@targos
Copy link
Member Author

targos commented Apr 14, 2024 

+ /usr/local/bin/node /home/runner/work/node/node/deps/npm/bin/npm-cli.js pkg set scripts.node-build=esbuild ./dist/cjs/index.js --bundle --platform=node --outfile=index.js
+ /usr/local/bin/node /home/runner/work/node/node/deps/npm/bin/npm-cli.js run node-build
Error: R] Could not resolve "./dist/cjs/index.js"

@marco-ippolito
Copy link
Member

the folder structure has been changed from ./dist/cjs/index.js to ./dist/commonjs/index.js. I'll open a fix shortly

@marco-ippolito marco-ippolito mentioned this issue Apr 14, 2024
Merged
nodejs-github-bot pushed a commit that referenced this issue Apr 15, 2024
@marco-ippolito
tools: update minimatch index path
0debfa4 
PR-URL: #52523
Fixes: #52520
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
aduh95 pushed a commit that referenced this issue Apr 29, 2024
@marco-ippolito @aduh95
tools: update minimatch index path
15c5686 
PR-URL: #52523
Fixes: #52520
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
marco-ippolito added a commit that referenced this issue May 2, 2024
@marco-ippolito
tools: update minimatch index path
babb6f9 
PR-URL: #52523
Fixes: #52520
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
marco-ippolito added a commit that referenced this issue May 3, 2024
@marco-ippolito
tools: update minimatch index path
c681336 
PR-URL: #52523
Fixes: #52520
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tools: update minimatch index path marco-ippolito/node
2 participants
@targos @marco-ippolito