Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport undici MessageEvent to v20. #53009

Closed
mcollina opened this issue May 15, 2024 · 3 comments
Closed

Backport undici MessageEvent to v20. #53009

mcollina opened this issue May 15, 2024 · 3 comments
Labels
tsc-agenda Issues and PRs to discuss during the meetings of the TSC.

Comments

@mcollina
Copy link
Member

#52370 is tagged as semver-major because it changes an error message to be spec-compliant.

I recommend we backport it to Node v22 to ease long-term maintenance.

@mcollina mcollina added the tsc-agenda Issues and PRs to discuss during the meetings of the TSC. label May 15, 2024
@mcollina
Copy link
Member Author

cc @KhafraDev

@KhafraDev
Copy link
Member

KhafraDev commented May 15, 2024

The errors were spec compliant, it's semver-major because it changed the error messages themselves. Since undici implements the webidl spec, and reuses it between everything web-related it implements, it's not feasible to match the errors to the old node ones (which were inconsistent).

I'd recommend backporting #52763 as well for better error messages and #52951 (when it lands) to make it fast.

@mcollina
Copy link
Member Author

In today's TSC meeting, we agreed to backport it to v22, but not v20 and v18. We'll see if it's problematic via CITGM (we don't expect it to be).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tsc-agenda Issues and PRs to discuss during the meetings of the TSC.
Projects
None yet
Development

No branches or pull requests

2 participants