-
Notifications
You must be signed in to change notification settings - Fork 29k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib: speed up MessageEvent creation internally #52951
lib: speed up MessageEvent creation internally #52951
Conversation
98377de
to
43aa76e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with benchmark ci
Benchmarks look great:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This comment was marked as outdated.
This comment was marked as outdated.
Commit Queue failed- Loading data for nodejs/node/pull/52951 ✔ Done loading data for nodejs/node/pull/52951 ----------------------------------- PR info ------------------------------------ Title lib: speed up MessageEvent creation internally (#52951) Author Khafra (@KhafraDev) Branch KhafraDev:use-fast-create-messageevent -> nodejs:main Labels author ready, worker, needs-ci Commits 2 - lib: speed up MessageEvent creation internally - fixup Committers 1 - Khafra PR-URL: https://github.com/nodejs/node/pull/52951 Refs: https://github.com/nodejs/undici/pull/3170 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Matteo Collina ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/52951 Refs: https://github.com/nodejs/undici/pull/3170 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Matteo Collina -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 12 May 2024 02:53:03 GMT ✔ Approvals: 2 ✔ - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/52951#pullrequestreview-2052434926 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/52951#pullrequestreview-2071390736 ✔ Last GitHub CI successful ℹ Last Benchmark CI on 2024-05-12T06:53:30Z: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1561/ ℹ Last Full PR CI on 2024-05-30T16:17:26Z: https://ci.nodejs.org/job/node-test-pull-request/59542/ - Querying data for job/node-test-pull-request/59542/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 52951 From https://github.com/nodejs/node * branch refs/pull/52951/merge -> FETCH_HEAD ✔ Fetched commits as 75fe4f35d4e5..29c44f31e535 -------------------------------------------------------------------------------- [main bac899986b] lib: speed up MessageEvent creation internally Author: Khafra Date: Sat May 11 22:49:27 2024 -0400 1 file changed, 6 insertions(+), 5 deletions(-) [main 849a35ded2] fixup Author: Khafra Date: Mon May 13 01:47:55 2024 -0400 1 file changed, 2 insertions(+) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4)https://github.com/nodejs/node/actions/runs/9532972963 |
Landed in 672e4cc |
createFastMessageEvent
can be used when the arguments passed to the MessageEvent constructor do not need to be validated.Refs: nodejs/undici#3170
Refs: #52370 (review)