-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node silently allows using dh and x25519 keys for signing / verification #53742
Labels
Comments
@nodejs/crypto PTAL |
JLHwung
added a commit
to JLHwung/node
that referenced
this issue
Jul 9, 2024
JLHwung
added a commit
to JLHwung/node
that referenced
this issue
Jul 9, 2024
JLHwung
added a commit
to JLHwung/node
that referenced
this issue
Jul 9, 2024
aduh95
pushed a commit
to aduh95/node
that referenced
this issue
Sep 24, 2024
Fixes: nodejs#53742 PR-URL: nodejs#53774 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
aduh95
pushed a commit
to aduh95/node
that referenced
this issue
Sep 25, 2024
Fixes: nodejs#53742 PR-URL: nodejs#53774 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
richardlau
pushed a commit
to aduh95/node
that referenced
this issue
Sep 27, 2024
Fixes: nodejs#53742 PR-URL: nodejs#53774 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
louwers
pushed a commit
to louwers/node
that referenced
this issue
Nov 2, 2024
Fixes: nodejs#53742 PR-URL: nodejs#53774 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
tpoisseau
pushed a commit
to tpoisseau/node
that referenced
this issue
Nov 21, 2024
Fixes: nodejs#53742 PR-URL: nodejs#53774 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Version
v22.4.0
Platform
Linux pop-os 6.9.3-76060903-generic #202405300957
171834820922.04~7817b67 SMP PREEMPT_DYNAMIC Mon J x86_64 x86_64 x86_64 GNU/LinuxSubsystem
crypto
What steps will reproduce the bug?
Produces output like:
How often does it reproduce? Is there a required condition?
Always
What is the expected behavior? Why is that the expected behavior?
Node throws an error that x25519 keys can not be used for signing. Same should happen for
dh
keys.What do you see instead?
(invalid output)
Additional information
No response
The text was updated successfully, but these errors were encountered: