Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sqlite repo label #53795

Closed
avivkeller opened this issue Jul 10, 2024 · 4 comments
Closed

sqlite repo label #53795

avivkeller opened this issue Jul 10, 2024 · 4 comments
Labels
meta Issues and PRs related to the general management of the project. sqlite Issues and PRs related to the SQLite subsystem.

Comments

@avivkeller
Copy link
Member

avivkeller commented Jul 10, 2024 •
edited
Loading

Given the landing of the new node:sqlite module, I believe the repo should gain a new sqlite label. (I posted this as a comment, but I figured an issue would gain more visibility)

Ref #53752 (comment)
@avivkeller avivkeller added the meta Issues and PRs related to the general management of the project. label Jul 10, 2024
@targos targos added the sqlite Issues and PRs related to the SQLite subsystem. label Jul 10, 2024
@targos
Copy link
Member

targos commented Jul 10, 2024

Done

@targos targos closed this as completed Jul 10, 2024
@targos
Copy link
Member

targos commented Jul 10, 2024

We should also allow the sqlite: subsystem it commit messages.

@avivkeller
Copy link
Member Author

We should also allow the sqlite: subsystem it commit messages.

I can open a PR later today

@avivkeller avivkeller mentioned this issue Jul 10, 2024
Merged
@avivkeller
Copy link
Member Author

#53797
nodejs/core-validate-commit#121

richardlau pushed a commit to nodejs/core-validate-commit that referenced this issue Aug 5, 2024
@avivkeller
feat(sqlite): add sqlite subsystem (#121)
87c1bac 
Ref: nodejs/node#53795 (comment)
Ref: nodejs/node#53752
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
meta Issues and PRs related to the general management of the project. sqlite Issues and PRs related to the SQLite subsystem.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@targos @avivkeller