Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PerformanceObserver.supportedEntryTypes does not match documented performanceEntry.entryType #54212

Closed
Semigradsky opened this issue Aug 5, 2024 · 1 comment · Fixed by #54263
Closed

PerformanceObserver.supportedEntryTypes does not match documented performanceEntry.entryType #54212

Semigradsky opened this issue Aug 5, 2024 · 1 comment · Fixed by #54263
Labels
doc Issues and PRs related to the documentations. perf_hooks Issues and PRs related to the implementation of the Performance Timing API.

Comments

@Semigradsky
Copy link
Contributor

Affected URL(s)

https://nodejs.org/docs/latest/api/perf_hooks.html#performanceentryentrytype

Description of the problem

By the doc the performance entry may be one of:

'node' (Node.js only)
'mark' (available on the Web)
'measure' (available on the Web)
'gc' (Node.js only)
'function' (Node.js only)
'http2' (Node.js only)
'http' (Node.js only)

But in code we have other supported entry types: https://github.com/nodejs/node/blob/ca2ed88f94ca537c21a631cfecf577aa96afca0b/lib/internal/perf/observe.js#L88C8-L98

> PerformanceObserver.supportedEntryTypes
[
  'dns',      'function',
  'gc',       'http',
  'http2',    'mark',
  'measure',  'net',
  'resource'
]

There are no documented dns, resource, net. And there is no node.
@Semigradsky Semigradsky added the doc Issues and PRs related to the documentations. label Aug 5, 2024
@Semigradsky Semigradsky mentioned this issue Aug 5, 2024
Merged
@avivkeller avivkeller added the perf_hooks Issues and PRs related to the implementation of the Performance Timing API. label Aug 5, 2024
@Semigradsky
Copy link
Contributor Author

Also related I think - #50290

jazelly added a commit to jazelly/node that referenced this issue Aug 8, 2024
@jazelly
doc: add missing performance entry types
531ed50 
Fixes: nodejs#54212
jazelly added a commit to jazelly/node that referenced this issue Aug 8, 2024
@jazelly
doc: correct peformance entry types
91d45f5 
Fixes: nodejs#54212
@jazelly jazelly mentioned this issue Aug 8, 2024
Merged
jazelly added a commit to jazelly/node that referenced this issue Aug 9, 2024
@jazelly
doc: correct peformance entry types
31d4f56 
Fixes: nodejs#54212
Fixes: nodejs#50290
jazelly added a commit to jazelly/node that referenced this issue Aug 9, 2024
@jazelly
doc: correct peformance entry types
0dabfa0 
Fixes: nodejs#54212
Fixes: nodejs#50290
RafaelGSS pushed a commit that referenced this issue Aug 19, 2024
@jazelly @RafaelGSS
doc: correct peformance entry types
814cb80 
Fixes: #54212
Fixes: #50290
PR-URL: #54263
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS pushed a commit that referenced this issue Aug 21, 2024
@jazelly @RafaelGSS
doc: correct peformance entry types
aa6e770 
Fixes: #54212
Fixes: #50290
PR-URL: #54263
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this issue Sep 21, 2024
@jazelly @targos
doc: correct peformance entry types
aa32059 
Fixes: #54212
Fixes: #50290
PR-URL: #54263
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this issue Sep 26, 2024
@jazelly @targos
doc: correct peformance entry types
b7d88c4 
Fixes: #54212
Fixes: #50290
PR-URL: #54263
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this issue Oct 2, 2024
@jazelly @targos
doc: correct peformance entry types
994b46a 
Fixes: #54212
Fixes: #50290
PR-URL: #54263
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. perf_hooks Issues and PRs related to the implementation of the Performance Timing API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: correct peformance entry types jazelly/node
2 participants
@Semigradsky @avivkeller