Respect NO_COLORenvironment variable when using styleText
#54365
Labels
feature request
Issues that request new features to be added to Node.js.
util
Issues and PRs related to the built-in util module.
Comments
todor-a
added
the
feature request
github-project-automation
bot
moved this to Awaiting Triage
in Node.js feature requests
|
A PR was started a while ago (but seems stalled): #51959 |
|
My bad. Searched through the issues but not through the PRs (rookie mistake). Should I close this? |
You don't have to, once this PR lands, it will automatically close this issue as completed. |
nodejs-github-bot
pushed a commit
that referenced
this issue
Aug 28, 2024
This PR changes styleText API to respect terminal capabilities and environment variables such as NO_COLOR, NODE_DISABLE_COLORS, and FORCE_COLOR. PR-URL: #54389 Fixes: #54365 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Claudio Wunder <cwunder@gnome.org> Reviewed-By: Rich Trott <rtrott@gmail.com>
RafaelGSS
added a commit
that referenced
this issue
Aug 30, 2024
This PR changes styleText API to respect terminal capabilities and environment variables such as NO_COLOR, NODE_DISABLE_COLORS, and FORCE_COLOR. PR-URL: #54389 Fixes: #54365 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Claudio Wunder <cwunder@gnome.org> Reviewed-By: Rich Trott <rtrott@gmail.com>
RafaelGSS
added a commit
that referenced
this issue
Aug 30, 2024
This PR changes styleText API to respect terminal capabilities and environment variables such as NO_COLOR, NODE_DISABLE_COLORS, and FORCE_COLOR. PR-URL: #54389 Fixes: #54365 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Claudio Wunder <cwunder@gnome.org> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this issue
Sep 22, 2024
This PR changes styleText API to respect terminal capabilities and environment variables such as NO_COLOR, NODE_DISABLE_COLORS, and FORCE_COLOR. PR-URL: #54389 Fixes: #54365 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Claudio Wunder <cwunder@gnome.org> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this issue
Sep 26, 2024
This PR changes styleText API to respect terminal capabilities and environment variables such as NO_COLOR, NODE_DISABLE_COLORS, and FORCE_COLOR. PR-URL: #54389 Fixes: #54365 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Claudio Wunder <cwunder@gnome.org> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this issue
Oct 2, 2024
This PR changes styleText API to respect terminal capabilities and environment variables such as NO_COLOR, NODE_DISABLE_COLORS, and FORCE_COLOR. PR-URL: #54389 Fixes: #54365 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Claudio Wunder <cwunder@gnome.org> Reviewed-By: Rich Trott <rtrott@gmail.com>
louwers
pushed a commit
to louwers/node
that referenced
this issue
Nov 2, 2024
This PR changes styleText API to respect terminal capabilities and environment variables such as NO_COLOR, NODE_DISABLE_COLORS, and FORCE_COLOR. PR-URL: nodejs#54389 Fixes: nodejs#54365 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Claudio Wunder <cwunder@gnome.org> Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What is the problem this feature will solve?
The
styleTextutility does not take into account ifNO_COLORis passed. It would be nice if it did.What is the feature you are proposing to solve the problem?
Before applying styles, check if
NO_COLORis set.Other tools, like picocolors, look at cli flags as well.
Would be happy to submit a PR.
What alternatives have you considered?
No response
The text was updated successfully, but these errors were encountered: