cpSync symlink handling regression

[PhilipTrauner]

Version

v22.6.0

Platform

Darwin Quantum 23.6.0 Darwin Kernel Version 23.6.0: Fri Jul  5 17:56:41 PDT 2024; root:xnu-10063.141.1~2/RELEASE_ARM64_T6000 arm6

Subsystem

fs

What steps will reproduce the bug?

override a directory with a symlink to a directory with {dereference: true}

How often does it reproduce? Is there a required condition?

consistently

What is the expected behavior? Why is that the expected behavior?

the source symlink should be derefenced

What do you see instead?

the source symlink is not derefenced

node/src/node_file.cc

Line 3158 in 298dea0

bool src_is_dir = src_status.type() == std::filesystem::file_type::directory;

Additional information

No response

[RedYetiDev]

Can you provide an example that shows this bug? That'll make it easier to reproduce

[jazelly]

I found a reproduce step.

1. create a original dir a, with some files inside
2. create a symlink b by ln -s ./a ./b
3. create a dir c to be overrided
4. execute the following script

import fs from 'fs';
fs.cpSync('./b', './c', { recursive: true, dereference: true})

5. observe ERR_FS_CP_NON_DIR_TO_DIR

This is not happening in 22.5.1

[RedYetiDev]

$ mkdir a
$ touch a/some_file
$ ln -s ./a ./b
$ mkdir c
$ node -e "fs.cpSync('./b', './c', { recursive: true, dereference: true})"

node:internal/fs/cp/cp-sync:56
  fsBinding.cpSyncCheckPaths(src, dest, opts.dereference, opts.recursive);
            ^

Error: Cannot overwrite directory ./c with non-directory ./b
    at cpSyncFn (node:internal/fs/cp/cp-sync:56:13)
    at Object.cpSync (node:fs:3046:3)
    at [eval]:1:4
    at runScriptInThisContext (node:internal/vm:209:10)
    at node:internal/process/execution:118:14
    at [eval]-wrapper:6:24
    at runScript (node:internal/process/execution:101:62)
    at evalScript (node:internal/process/execution:136:3)
    at node:internal/main/eval_string:55:3 {
  code: 'ERR_FS_CP_NON_DIR_TO_DIR'
}

Node.js v22.7.0