Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nominating @pmarchini to be a collaborator #55053

Closed
cjihrig opened this issue Sep 21, 2024 · 4 comments · Fixed by #55331
Closed

Nominating @pmarchini to be a collaborator #55053

cjihrig opened this issue Sep 21, 2024 · 4 comments · Fixed by #55331
Labels
meta Issues and PRs related to the general management of the project.

Comments

@cjihrig
Copy link
Contributor

cjihrig commented Sep 21, 2024

They have been helping out a lot with the test runner and tests. Being able to run the CI would be helpful and I think they have enough commits and involvement in the Node.js repos to warrant a collaborator nomination.

Commits authored on nodejs/node: github.com/nodejs/node/commits?author=pmarchini
Pull requests opened: github.com/search?q=author:pmarchini+org:nodejs&type=pullrequests
Issues opened: github.com/search?q=author:pmarchini+org:nodejs&type=issues
Comments on pull requests and issues throughout the Node.js organization: https://github.com/search?q=commenter%3Apmarchini+org%3Anodejs&type=pullrequests

Private nomination (visible to collaborators only): https://github.com/nodejs/collaborators/discussions/204

cc: @pmarchini @nodejs/collaborators

@cjihrig cjihrig added the meta Issues and PRs related to the general management of the project. label Sep 21, 2024
@mcollina
Copy link
Member

+1 I can help with the onboarding starting from the 9th of October.

@marco-ippolito
Copy link
Member

+1 if nobody onboards him before the 4th of October, I can volunteer do it since we live nearby

@MoLow
Copy link
Member

MoLow commented Sep 29, 2024

+1

@marco-ippolito
Copy link
Member

marco-ippolito commented Oct 1, 2024

I can onboard @pmarchini Wednsday 9th October 10am (Italy time) we will be in person, but we can stream if anyone else wants to join.

pmarchini added a commit to pmarchini/node that referenced this issue Oct 9, 2024
pmarchini added a commit to pmarchini/node that referenced this issue Oct 9, 2024
pmarchini added a commit to pmarchini/node that referenced this issue Oct 9, 2024
aduh95 pushed a commit that referenced this issue Oct 9, 2024
Fixes: #55053
PR-URL: #55331
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 pushed a commit that referenced this issue Oct 9, 2024
Fixes: #55053
PR-URL: #55331
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
louwers pushed a commit to louwers/node that referenced this issue Nov 2, 2024
Fixes: nodejs#55053
PR-URL: nodejs#55331
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
marco-ippolito pushed a commit that referenced this issue Nov 16, 2024
Fixes: #55053
PR-URL: #55331
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
marco-ippolito pushed a commit that referenced this issue Nov 17, 2024
Fixes: #55053
PR-URL: #55331
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
tpoisseau pushed a commit to tpoisseau/node that referenced this issue Nov 21, 2024
Fixes: nodejs#55053
PR-URL: nodejs#55331
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants