Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc/api/tls.markdown needs punctuation fixes #5672

Closed
Trott opened this issue Mar 12, 2016 · 1 comment
Closed

doc/api/tls.markdown needs punctuation fixes #5672

Trott opened this issue Mar 12, 2016 · 1 comment
Labels
doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors. tls Issues and PRs related to the tls subsystem.

Comments

@Trott
Copy link
Member

Trott commented Mar 12, 2016

This is a good first contribution for someone looking for such a thing.

There appear to be approximately seven uses of - in the prose of tls.markdown. Its usage in that document is mostly non-idiomatic. Most or all of them would be better as commas or other punctuation.
@Trott Trott added tls Issues and PRs related to the tls subsystem. doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors. labels Mar 12, 2016
@svozza svozza mentioned this issue Mar 12, 2016
Closed
@claudiorodriguez claudiorodriguez mentioned this issue Mar 12, 2016
Closed
@svozza
Copy link
Contributor

svozza commented Mar 13, 2016

I've picked this up, PR @ #5677.

svozza added a commit to svozza/node that referenced this issue Mar 14, 2016
@svozza
doc: remove non-standard use of hyphens
9ad2ebd 
Identifies the non-idiomatic usages of the '-' character
and either removes them or replaces them with colons.

Fixes: nodejs#5672
evanlucas pushed a commit that referenced this issue Mar 14, 2016
@svozza @evanlucas
doc: remove non-standard use of hyphens
2a3394f 
Identifies the non-idiomatic usages of the '-' character
and either removes them or replaces them with colons.

Fixes: #5672
R-URL: #5677
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
rvagg pushed a commit that referenced this issue Mar 16, 2016
@svozza @rvagg
doc: remove non-standard use of hyphens
31e39fb 
Identifies the non-idiomatic usages of the '-' character
and either removes them or replaces them with colons.

Fixes: #5672
R-URL: #5677
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
MylesBorins pushed a commit that referenced this issue Mar 17, 2016
@svozza
doc: remove non-standard use of hyphens
e4817bb 
Identifies the non-idiomatic usages of the '-' character
and either removes them or replaces them with colons.

Fixes: #5672
R-URL: #5677
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
MylesBorins pushed a commit that referenced this issue Mar 21, 2016
@svozza
doc: remove non-standard use of hyphens
d8eeca4 
Identifies the non-idiomatic usages of the '-' character
and either removes them or replaces them with colons.

Fixes: #5672
R-URL: #5677
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
MylesBorins pushed a commit that referenced this issue Mar 21, 2016
@svozza
doc: remove non-standard use of hyphens
c6dc561 
Identifies the non-idiomatic usages of the '-' character
and either removes them or replaces them with colons.

Fixes: #5672
R-URL: #5677
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Trott @svozza