Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deleting property in vm context has no effect #6287

Closed
deian opened this issue Apr 19, 2016 · 2 comments
Closed

deleting property in vm context has no effect #6287

deian opened this issue Apr 19, 2016 · 2 comments
Labels
vm Issues and PRs related to the vm subsystem.

Comments

@deian
Copy link
Member

deian commented Apr 19, 2016

  • Version: 4.4.3, 5.10.1
  • Platform: Arch Linux 4.5.0

Example failure:

const vm = require('vm');
const sbox = { };
vm.createContext(sbox);
vm.runInContext(`
  this.x = 'w00t';
  delete this.x;
`, sbox);

console.log(sbox); // { x: 'w00t' }

Expected sbox.x to be undefined.
@mscdex mscdex added the vm Issues and PRs related to the vm subsystem. label Apr 19, 2016
@jasnell
Copy link
Member

jasnell commented Apr 19, 2016

Related to #6283

@ofrobots ofrobots mentioned this issue Apr 22, 2016
Closed
12 tasks
@vladimir-kotikov vladimir-kotikov mentioned this issue Nov 15, 2016
Closed
@i8-pi i8-pi mentioned this issue Dec 11, 2016
Closed
AnnaMag added a commit to AnnaMag/node that referenced this issue Dec 14, 2016
@AnnaMag
test: add known_issues test for nodejs#6287
527ef53 
Deleting property in the vm context has no effect
nodejs#6287
The test is moved to the known_issues and will be fixed
with the 5.5 V8 API changes.
@AnnaMag AnnaMag mentioned this issue Dec 14, 2016
Closed
3 tasks
AnnaMag added a commit to AnnaMag/node that referenced this issue Dec 14, 2016
@AnnaMag
test: add known_issues test for nodejs#6287
6dc6f09 
Deleting property in the vm context has no effect
as reported in nodejs#6287
The test is moved to the known_issues and will be fixed
with the 5.5 V8 API changes.
@AnnaMag AnnaMag mentioned this issue Dec 14, 2016
Closed
3 tasks
AnnaMag added a commit to AnnaMag/node that referenced this issue Dec 16, 2016
@AnnaMag
test: add known_issues test for nodejs#6287
8667063 
Deleting property in the vm context has no effect
as reported in nodejs#6287
The test is moved to the known_issues and will be fixed
with the 5.5 V8 API changes.
italoacasas pushed a commit that referenced this issue Dec 18, 2016
@AnnaMag @italoacasas
test: add known_issues test for #6287
0d3ac89 
Deleting property in the vm context has no effect
as reported in #6287
The test is moved to the known_issues and will be fixed
with the 5.5 V8 API changes.

PR-URL: #10272
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
cjihrig pushed a commit to cjihrig/node that referenced this issue Dec 20, 2016
@AnnaMag @cjihrig
test: add known_issues test for nodejs#6287
a20480c 
Deleting property in the vm context has no effect
as reported in nodejs#6287
The test is moved to the known_issues and will be fixed
with the 5.5 V8 API changes.

PR-URL: nodejs#10272
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@italoacasas italoacasas mentioned this issue Dec 20, 2016
Merged
cjihrig pushed a commit that referenced this issue Dec 20, 2016
@AnnaMag @cjihrig
test: add known_issues test for #6287
1726a17 
Deleting property in the vm context has no effect
as reported in #6287
The test is moved to the known_issues and will be fixed
with the 5.5 V8 API changes.

PR-URL: #10272
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this issue Jan 23, 2017
@AnnaMag @MylesBorins
test: add known_issues test for #6287
105123e 
Deleting property in the vm context has no effect
as reported in #6287
The test is moved to the known_issues and will be fixed
with the 5.5 V8 API changes.

PR-URL: #10272
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this issue Jan 24, 2017
@AnnaMag @MylesBorins
test: add known_issues test for #6287
6ad8a6e 
Deleting property in the vm context has no effect
as reported in #6287
The test is moved to the known_issues and will be fixed
with the 5.5 V8 API changes.

PR-URL: #10272
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins mentioned this issue Jan 24, 2017
Merged
MylesBorins pushed a commit that referenced this issue Jan 31, 2017
@AnnaMag @MylesBorins
test: add known_issues test for #6287
c604016 
Deleting property in the vm context has no effect
as reported in #6287
The test is moved to the known_issues and will be fixed
with the 5.5 V8 API changes.

PR-URL: #10272
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@fhinkel fhinkel mentioned this issue Feb 9, 2017
Closed
3 tasks
fhinkel added a commit to fhinkel/node that referenced this issue Feb 10, 2017
@fhinkel
src: fix delete operator on vm context
7c00321 
In the implementation of the vm module,
if a property is successfully deleted
on the sandbox, we also need to delete it
on the global_proxy object. Therefore, we
must not call args.GetReturnValue().Set().

We only intercept, i.e., call
args.GetReturnValue().Set(), in the
DeleterCallback, if Delete() failed, e.g. because
the property was read only.

Fixes nodejs#6287
@fhinkel
Copy link
Member

fhinkel commented Feb 13, 2017

Fixed in #11266

@fhinkel fhinkel closed this as completed Feb 13, 2017
@domenic domenic mentioned this issue Feb 14, 2017
Closed
@jfirebaugh jfirebaugh mentioned this issue Mar 23, 2017
Closed
@domenic domenic mentioned this issue Feb 2, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
vm Issues and PRs related to the vm subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

src: fix delete operator on vm context fhinkel/node
4 participants
@mscdex @fhinkel @deian @jasnell