Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix exec stdout & stderr default type in child_process #6666

Closed
sartrey opened this issue May 10, 2016 · 2 comments
Closed

doc: fix exec stdout & stderr default type in child_process #6666

sartrey opened this issue May 10, 2016 · 2 comments
Labels
child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to the documentations.

Comments

@sartrey
Copy link
Contributor

sartrey commented May 10, 2016

  • v4.4.4:
  • Darwin:

There is an inaccurate line in child_process documents.
** origin text **
If encoding is 'buffer', Buffer objects will be passed to
the callback instead

Actually, if encoding parameter can not be identified as encoding (Buffer.isEncoding)
exec will also output buffer rather than string

Could I provide a pr to fix the document?
@mscdex mscdex added child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to the documentations. labels May 10, 2016
@cjihrig
Copy link
Contributor

cjihrig commented May 15, 2016

Could I provide a pr to fix the document?

Sure.

@cryptoquick
Copy link

I hope we are aware this is the most evilest node.js issue. 😈

@akrawchyk akrawchyk mentioned this issue Jun 15, 2016
Closed
@sartrey sartrey mentioned this issue Jun 22, 2016
Closed
2 tasks
Fishrock123 pushed a commit that referenced this issue Jul 5, 2016
@sartrey @Fishrock123
doc: clarify child_process stdout/stderr types
44bc638 
Clarify how the encoding option interacts with the data
type of child process stdout and stderr.

Fixes: #6666
PR-URL: #7361
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this issue Jul 11, 2016
@sartrey
doc: clarify child_process stdout/stderr types
101f7be 
Clarify how the encoding option interacts with the data
type of child process stdout and stderr.

Fixes: #6666
PR-URL: #7361
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this issue Jul 12, 2016
@sartrey @MylesBorins
doc: clarify child_process stdout/stderr types
3ce574e 
Clarify how the encoding option interacts with the data
type of child process stdout and stderr.

Fixes: #6666
PR-URL: #7361
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this issue Jul 12, 2016
@sartrey
doc: clarify child_process stdout/stderr types
b17a58c 
Clarify how the encoding option interacts with the data
type of child process stdout and stderr.

Fixes: #6666
PR-URL: #7361
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this issue Jul 12, 2016
@sartrey
doc: clarify child_process stdout/stderr types
71c68e0 
Clarify how the encoding option interacts with the data
type of child process stdout and stderr.

Fixes: #6666
PR-URL: #7361
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this issue Jul 14, 2016
@sartrey
doc: clarify child_process stdout/stderr types
6f5d939 
Clarify how the encoding option interacts with the data
type of child process stdout and stderr.

Fixes: #6666
PR-URL: #7361
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this issue Jul 14, 2016
@sartrey
doc: clarify child_process stdout/stderr types
35ee35c 
Clarify how the encoding option interacts with the data
type of child process stdout and stderr.

Fixes: #6666
PR-URL: #7361
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mscdex @cryptoquick @cjihrig @sartrey