Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contribution policy addition request #67

Closed
rvagg opened this issue Dec 4, 2014 · 2 comments
Closed

Contribution policy addition request #67

rvagg opened this issue Dec 4, 2014 · 2 comments

Comments

@rvagg
Copy link
Member

rvagg commented Dec 4, 2014

To those here that are obsessive about avoiding merge commits please expand the contribution policy with technical details about how to land patches to (1) avoid merge commits and (2) keep a healthy git log in the process. I find the process kind of infuriating and have messed up the commit log slightly while landing the last few PRs.

The contribution policy is also lacking technical details about how committers should be keeping contributions to a single commit, ammending to insert the requested tags, and other minor details; it's a bit too hand wavy for a project that has built up an rigid set of conventions about how to git.

@ralphtheninja
Copy link
Contributor

👍

indutny added a commit to indutny/io.js that referenced this issue Dec 4, 2014
Describe in details how our current git flow works and could be used.
Fix nodejs#67
@indutny
Copy link
Member

indutny commented Dec 4, 2014

@rvagg should be fixed by #68, please follow the steps when landing it ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants