-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate flaky test-preload.js #6722
Comments
/cc @nodejs/testing |
/cc @Fishrock123 |
Not sure why we now have 3 issues open, so I'll close the AIX one. PR (WIP now): #6718 |
Also failing intermittently on CentOS 7 64-bit: |
Use `close` event rather than `exit` event to make sure all output has been received before checking assertions. Fixes: nodejs#6722
Here's a new one: https://ci.nodejs.org/job/node-test-commit-linux/3370/nodes=centos7-64/tapTestReport/test.tap-676/ from #5958
Haven't seen this output before. |
And another (also centos7-64): https://ci.nodejs.org/job/node-test-commit-linux/3379/nodes=centos7-64/console
|
Use `close` event rather than `exit` event to make sure all output has been received before checking assertions. PR-URL: #6728 Fixes: #6722 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Use `close` event rather than `exit` event to make sure all output has been received before checking assertions. Fixes: nodejs#6722
Failure in CI:
https://ci.nodejs.org/job/node-test-commit-linux/3349/nodes=centos5-32/tapTestReport/test.tap-677/
/cc @bmeck
The text was updated successfully, but these errors were encountered: