Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

segment fault when compile node 0.1x branch with gcc 6.1.1 in 64bit linux #6724

Closed
vitalybupt opened this issue May 13, 2016 · 4 comments
Closed

segment fault when compile node 0.1x branch with gcc 6.1.1 in 64bit linux #6724

vitalybupt opened this issue May 13, 2016 · 4 comments
Labels
build Issues and PRs related to build files or the CI.

Comments

@vitalybupt
Copy link

after update gcc version from 5.3 to 6.1.1, the compile of node 0.12.7 failed with segment fault, this issue not happened when compile debug version and i compile 0.12.14 the issue still exist and it disappeared after remove -O3 from makefile.
debug the issue found the reason is:
#0 v8::internal::PagedSpace::Contains (addr=0x0, this=0xd61ff0) at ../deps/v8/src/heap/spaces-inl.h:152 152 return p->owner() == this;
the input argument addr is null, after add a check for the input argument, this issue disappear.
@mscdex mscdex added v0.12 build Issues and PRs related to build files or the CI. labels May 13, 2016
@bnoordhuis
Copy link
Member

Try building with make CXX="g++ -fno-delete-null-pointer-checks". v0.12 is in maintenance mode and close to being EOL'd so I don't think we'll fix this.

Perhaps if we do another v0.12 release (big if), we could add -fno-delete-null-pointer-checks to the default build flags.

bnoordhuis added a commit to bnoordhuis/io.js that referenced this issue May 13, 2016
@bnoordhuis
build: turn on -fno-delete-null-pointer-checks
67e7b6c 
Work around spec violations in V8 where it checks that `this == NULL`.
GCC 6 started exploiting this particular kind of UB, resulting in
runtime crashes.

Fixes: nodejs#6724
@bnoordhuis bnoordhuis mentioned this issue May 13, 2016
Closed
bnoordhuis added a commit to bnoordhuis/io.js that referenced this issue May 13, 2016
@bnoordhuis
build: turn on -fno-delete-null-pointer-checks
f2b219c 
Work around spec violations in V8 where it checks that `this == NULL`.
GCC 6 started exploiting this particular kind of UB, resulting in
runtime crashes.

Fixes: nodejs#6724
@bnoordhuis bnoordhuis mentioned this issue May 13, 2016
Closed
@bnoordhuis
Copy link
Member

Perhaps if we do another v0.12 release (big if), we could add -fno-delete-null-pointer-checks to the default build flags.

I filed #6737 and #6738 for v0.12 and v0.10 respectively.

jasnell pushed a commit that referenced this issue May 25, 2016
@bnoordhuis @jasnell
build: turn on -fno-delete-null-pointer-checks
fc6d820 
Work around spec violations in V8 where it checks that `this == NULL`.
GCC 6 started exploiting this particular kind of UB, resulting in
runtime crashes.

Fixes: #6724
PR-URL: #6737
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
rvagg pushed a commit that referenced this issue Jun 23, 2016
@bnoordhuis @rvagg
build: turn on -fno-delete-null-pointer-checks
7f44ecf 
Work around spec violations in V8 where it checks that `this == NULL`.
GCC 6 started exploiting this particular kind of UB, resulting in
runtime crashes.

Fixes: #6724
PR-URL: #6738
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
rvagg pushed a commit that referenced this issue Sep 22, 2016
@bnoordhuis @rvagg
build: turn on -fno-delete-null-pointer-checks
1ba6d16 
Work around spec violations in V8 where it checks that `this == NULL`.
GCC 6 started exploiting this particular kind of UB, resulting in
runtime crashes.

Fixes: #6724
PR-URL: #6737
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
rvagg pushed a commit that referenced this issue Sep 22, 2016
@bnoordhuis @rvagg
build: turn on -fno-delete-null-pointer-checks
35b49ed 
Work around spec violations in V8 where it checks that `this == NULL`.
GCC 6 started exploiting this particular kind of UB, resulting in
runtime crashes.

Fixes: #6724
PR-URL: #6738
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
jBarz pushed a commit to ibmruntimes/node that referenced this issue Nov 4, 2016
@bnoordhuis @jBarz
build: turn on -fno-delete-null-pointer-checks
2f9e70f 
Work around spec violations in V8 where it checks that `this == NULL`.
GCC 6 started exploiting this particular kind of UB, resulting in
runtime crashes.

Fixes: nodejs/node#6724
PR-URL: nodejs/node#6737
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
@jasnell
Copy link
Member

jasnell commented Dec 29, 2016

Closing this given that support for v0.12 is coming to a close in two days and there will not be any further updates to the v0.12 branch.

@jasnell jasnell closed this as completed Dec 29, 2016
@bnoordhuis
Copy link
Member

For posterity: this was fixed in v0.10.47 and v0.12.16, released in September 2016.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mscdex @bnoordhuis @jasnell @vitalybupt