-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: formatting issues for child_process docs #6911
Comments
I'm starting work on this issue. cc: @evanlucas |
@rodmachen Sorry! Seems there was a race condition here. |
I have fixed the "backslash in backticks" issue and that commit is included in the PR. The I'm open to suggestions. |
/cc @nodejs/documentation What does everyone think about the current styling of backtick-enclosed links? |
Ref: nodejs#6911 Ref: nodejs#5075 PR-URL: nodejs#6952 Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com>
May I work on this if there's more work to be done? |
@mscdex ... still an issue? |
Going to close out this issue since the maxBuffer specific problem was fixed. Please feel free to open a new issue regarding backtick-enclosed links if still necessary! |
There are some formatting issues for
exec()
andexecFile()
in thechild_process
docs. Specifically:f85412d erroneously added a backslash in front of an asterisk that was already contained within backticks. This causes the backslash to show up when rendered. The backslash can be safely removed.Fixed by ed11ac6.maxBuffer
link is not styled like the other properties listed and looks out of place. My suggestion would be to have<code>
-wrapped content within links to continue to have the same gray background color normally, but switch to the green background color on hover like normal links. There may be other instances of this in the docs, I have not checked.The text was updated successfully, but these errors were encountered: