-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
module.children doesn't contain cached modules #7131
Labels
module
Issues and PRs related to the module subsystem.
Comments
I guess the question is: Is this a code bug or a documentation issue? I suspect the latter. Not sure who to ping for an opinion. Let's try @nodejs/ctc |
I'd say it's a bug. I have a potential fix in #14132. |
bnoordhuis
added a commit
to bnoordhuis/io.js
that referenced
this issue
Jul 24, 2017
`module.children` is supposed to be the list of modules included by this module but lib/module.js failed to update the list when the included module was retrieved from `Module._cache`. Fixes: nodejs#7131 PR-URL: nodejs#14132 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
addaleax
pushed a commit
that referenced
this issue
Jul 24, 2017
`module.children` is supposed to be the list of modules included by this module but lib/module.js failed to update the list when the included module was retrieved from `Module._cache`. Fixes: #7131 PR-URL: #14132 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
main.js
a.js
b.js, c.js
//some code
If we run
main.js
we have children array only withc.js
becauseb.js
was cachedThe text was updated successfully, but these errors were encountered: