-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
node docs issue in child_process #7269
Labels
child_process
Issues and PRs related to the child_process subsystem.
doc
Issues and PRs related to the documentations.
Comments
this can be tested by just seeing if the child process is still around after killing the parent |
mscdex
added
child_process
Issues and PRs related to the child_process subsystem.
doc
Issues and PRs related to the documentations.
labels
Jun 11, 2016
Would you be willing to file a pull request for this? The text to change is located in https://github.com/nodejs/node/blob/master/doc/api/child_process.md |
Yeah will do, will verify that it's correct first |
@ORESoftware I believe we do want the change you mentioned. |
cjihrig
added a commit
to cjihrig/node
that referenced
this issue
Jul 6, 2016
The example changed by this commit uses ['ignore'] where 'ignore' is intended. Fixes: nodejs#7269 PR-URL: nodejs#7540 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
child_process
Issues and PRs related to the child_process subsystem.
doc
Issues and PRs related to the documentations.
Using child_process.spawn, I believe the docs are incorrect (simple typo with drastic consequences) when using the stdio option:
the above should be correct, if you wish to create a child_process that is the leader of a new process group, that won't die if the parent is killed.
However, the child_process docs have this:
https://nodejs.org/api/child_process.html#child_process_options_detached
I don't believe the above is correct, although this may work:
this issue had me stuck for a few days :)
The text was updated successfully, but these errors were encountered: