Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate flaky test-tls-wrap-timeout on FreeBSD #7650

Closed
Trott opened this issue Jul 11, 2016 · 5 comments
Closed

Investigate flaky test-tls-wrap-timeout on FreeBSD #7650

Trott opened this issue Jul 11, 2016 · 5 comments
Labels
freebsd Issues and PRs related to the FreeBSD platform. test Issues and PRs related to the tests. tls Issues and PRs related to the tls subsystem.

Comments

@Trott
Copy link
Member

Trott commented Jul 11, 2016

https://ci.nodejs.org/job/node-test-commit-freebsd/3227/nodes=freebsd10-64/console

not ok 1027 parallel/test-tls-wrap-timeout
# /usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd10-64/test/parallel/test-tls-wrap-timeout.js:32
#       throw new Error('timeout');
#       ^
# 
# Error: timeout
#     at Socket.<anonymous> (/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd10-64/test/parallel/test-tls-wrap-timeout.js:32:13)
#     at Socket.g (events.js:286:16)
#     at emitNone (events.js:86:13)
#     at Socket.emit (events.js:185:7)
#     at Socket._onTimeout (net.js:333:8)
#     at tryOnTimeout (timers.js:224:11)
#     at Timer.listOnTimeout (timers.js:198:5)
  ---
  duration_ms: 0.951
@Trott Trott added tls Issues and PRs related to the tls subsystem. test Issues and PRs related to the tests. freebsd Issues and PRs related to the FreeBSD platform. labels Jul 11, 2016
@Trott
Copy link
Member Author

Trott commented Jul 23, 2016

Another one today: https://ci.nodejs.org/job/node-test-commit-freebsd/3416/nodes=freebsd10-64/console

not ok 1032 parallel/test-tls-wrap-timeout
# /usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd10-64/test/parallel/test-tls-wrap-timeout.js:32
#       throw new Error('timeout');
#       ^
# 
# Error: timeout
#     at Socket.<anonymous> (/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd10-64/test/parallel/test-tls-wrap-timeout.js:32:13)
#     at Socket.g (events.js:286:16)
#     at emitNone (events.js:86:13)
#     at Socket.emit (events.js:185:7)
#     at Socket._onTimeout (net.js:333:8)
#     at tryOnTimeout (timers.js:228:11)
#     at Timer.listOnTimeout (timers.js:202:5)
  ---
  duration_ms: 1.28

@Trott
Copy link
Member Author

Trott commented Jul 23, 2016 •
edited
Loading

Competing timers. @nodejs/testing

@Trott
Copy link
Member Author

Trott commented Jul 23, 2016

Hooray! I think I have a fix. (@SomeKittens and I put our heads together to fix this while mentoring at a NodeSchool event.) PR coming soon.

@Trott Trott mentioned this issue Jul 23, 2016
Closed
2 tasks
@Trott
Copy link
Member Author

Trott commented Jul 23, 2016

Proposed fix: #7857

@santigimeno
Copy link
Member

Another one: https://ci.nodejs.org/job/node-test-commit-freebsd/3461/nodes=freebsd10-64/

@santigimeno santigimeno mentioned this issue Jul 27, 2016
Merged
3 tasks
Trott added a commit to Trott/io.js that referenced this issue Jul 31, 2016
@Trott
test: fix flaky test-tls-wrap-timeout
2b17997 
Competing timers were causing a race condition and thus the test was
flaky. Instead, we check an object property on process exit.

Fixes: nodejs#7650
@Trott Trott closed this as completed in bc464a8 Jul 31, 2016
cjihrig pushed a commit that referenced this issue Aug 10, 2016
@Trott @cjihrig
test: fix flaky test-tls-wrap-timeout
10f0c94 
Competing timers were causing a race condition and thus the test was
flaky. Instead, we check an object property on process exit.

Fixes: #7650
PR-URL: #7857
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: jasnell - James M Snell <jasnell@gmail.com>
BethGriggs pushed a commit to BethGriggs/node that referenced this issue Apr 21, 2017
@Trott @BethGriggs
test: fix flaky test-tls-wrap-timeout
d428023 
Competing timers were causing a race condition and thus the test was
flaky. Instead, we check an object property on process exit.

Fixes: nodejs#7650
PR-URL: nodejs#7857
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: jasnell - James M Snell <jasnell@gmail.com>
@BethGriggs BethGriggs mentioned this issue Apr 21, 2017
Closed
2 tasks
MylesBorins pushed a commit that referenced this issue May 2, 2017
@Trott @MylesBorins
test: fix flaky test-tls-wrap-timeout
6040efd 
Competing timers were causing a race condition and thus the test was
flaky. Instead, we check an object property on process exit.

Fixes: #7650
Backport-PR-URL: #12567
PR-URL: #7857
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: jasnell - James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
freebsd Issues and PRs related to the FreeBSD platform. test Issues and PRs related to the tests. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Trott @santigimeno