Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update _stream_readable.js to delete invalid parameter. #8153

Closed
izengliang opened this issue Aug 18, 2016 · 2 comments
Closed

Update _stream_readable.js to delete invalid parameter. #8153

izengliang opened this issue Aug 18, 2016 · 2 comments
Labels
stream Issues and PRs related to the stream subsystem.

Comments

@izengliang
Copy link

Update _stream_readable.js to delete invalid parameter.

https://github.com/liangzeng/node/commit/acbb6d5489e31a35b8bc54060b5fabab6edbc6f0
@addaleax addaleax added the stream Issues and PRs related to the stream subsystem. label Aug 18, 2016
@addaleax
Copy link
Member

Hi @liangzeng! You’re right, that change seems to make sense. Do you want to try and open a pull request with it? There is a bit of information on how pull requests should look like in the CONTRIBUTING.md, and feel free to ask anything here if you’re not sure about something.

@izengliang
Copy link
Author

@addaleax thanks, i do.

addaleax pushed a commit to addaleax/node that referenced this issue Apr 30, 2017
@addaleax
stream: remove unnecessary parameter
5b4c475 
Delete invalid parameter.

Fixes: nodejs#8153
@addaleax addaleax mentioned this issue Apr 30, 2017
Closed
2 tasks
anchnk pushed a commit to anchnk/node that referenced this issue May 6, 2017
stream: remove unnecessary parameter
61a8ea3 
Delete invalid parameter.

Fixes: nodejs#8153
PR-URL: nodejs#12767
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Cai <davidcai1993@yahoo.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
gibfahn pushed a commit that referenced this issue Jun 18, 2017
@gibfahn
stream: remove unnecessary parameter
2532fb4 
Delete invalid parameter.

Fixes: #8153
PR-URL: #12767
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Cai <davidcai1993@yahoo.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
gibfahn pushed a commit that referenced this issue Jun 20, 2017
@gibfahn
stream: remove unnecessary parameter
975ef87 
Delete invalid parameter.

Fixes: #8153
PR-URL: #12767
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Cai <davidcai1993@yahoo.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this issue Jul 11, 2017
@MylesBorins
stream: remove unnecessary parameter
48a923a 
Delete invalid parameter.

Fixes: #8153
PR-URL: #12767
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Cai <davidcai1993@yahoo.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@addaleax @izengliang