New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream, test: Add test for _writableState state machine #8686

Closed

mcollina opened this issue Sep 21, 2016 · 12 comments

Labels

good first issue stream test

Member

mcollina commented Sep 21, 2016 •

edited

Loading

Version: all
Platform: all
Subsystem: stream, test

Part of #8644

stream._writableState.needDrain
stream._writableState.ending
stream._writableState.ended
stream._writableState.finished

node/lib/_stream_writable.js

Lines 46 to 52 in 774146d

    
           this.needDrain = false; 
        
           // at the start of calling end() 
        
           this.ending = false; 
        
           // when end() has been called, and returned 
        
           this.ended = false; 
        
           // when 'finish' is emitted 
        
           this.finished = false;

cc @Fishrock123 @nodejs/streams

mcollina added stream test good first issue labels

This was referenced Sep 22, 2016

test: stream._writableState.ending #8707

Closed

adding test for _stream.writable ended state #8778

Closed

addin test for _stream.writable finished state #8791

Closed

corykitchens commented Sep 26, 2016

@mcollina @Fishrock123 I'd love to take a shot at this as a first contribution. Who would be the main point of contact in regards to questions/comments/etc?

Member Author

mcollina commented Sep 26, 2016

You can target @nodejs/stream, or myself.

Contributor

italoacasas commented Sep 26, 2016

@corykitchens I already have 3/4 PR open, the only available is the needDrain flag, if you want to do it let me know and I just move to another Issue.

Member Author

mcollina commented Sep 26, 2016

@italoacasas unfortunately @nodejs/streams or myself was not tagged, and github do not send notification of open PR referencing an issue, sigh.

I'll get them reviewed asap.

corykitchens commented Sep 26, 2016

@italoacasas Yes sounds good, I'll work on whatever needs to get done.

Member Author

mcollina commented Sep 26, 2016

@italoacasas Can you please just use stream for the tests, instead of files? It makes things harder to port to readable-stream otherwise.

Contributor

italoacasas commented Sep 26, 2016 •

edited

Loading

@corykitchens it's at to you, just let me know.

@mcollina I'll make the change tonight, thanks for the feedback.

italoacasas mentioned this issue

adding test for _stream_writable.js needDrain state #8799

Closed

4 tasks

Member Author

mcollina commented Sep 29, 2016

@italoacasas can you please add something in your tests, they all look the same for those variables, but they are not. I would really like to see a tests where those variables are different.

Contributor

italoacasas commented Sep 30, 2016 •

edited

Loading

@mcollina I think I understand what you mean, I'm going to refactor the tests. Thanks for the feedback.

Member Author

mcollina commented Sep 30, 2016 •

edited

Loading

@italoacasas you are welcome! Let me know if you need any help, I will leave the PR non-merged atm waiting for another one.

mcollina pushed a commit that referenced this issue


          test: stream writable ended state

5e6bd84

PR-URL: #8778
Ref: #8686
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

jasnell pushed a commit that referenced this issue


          test: stream writable ended state

2ecd3b5

PR-URL: #8778
Ref: #8686
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins pushed a commit that referenced this issue


          test: stream writable ended state

89f2221

PR-URL: #8778
Ref: #8686
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins pushed a commit that referenced this issue


          test: stream writable ended state

81e60f4

PR-URL: #8778
Ref: #8686
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Fishrock123 pushed a commit that referenced this issue


          test: stream writable ended state

4fa0fc5

PR-URL: #8778
Ref: #8686
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

rvagg pushed a commit that referenced this issue


          test: stream writable ended state

5e5d034

PR-URL: #8778
Ref: #8686
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins pushed a commit that referenced this issue


          test: stream writable ended state

c543f4a

PR-URL: #8778
Ref: #8686
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

mcollina pushed a commit that referenced this issue


          test: writable stream finished state

f12338d

Add a test for _writableState.finished.

PR-URL: #8791
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Related: #8686

mcollina pushed a commit that referenced this issue


          test: writable stream ending state

fd16eed

Add a test for _writableState.ending, when ending becomes true,
but the stream is not finished/ended yet.

PR-URL: #8707
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Related: #8686

mcollina pushed a commit that referenced this issue


          test: writable stream needDrain state

9ed7261

Add a test for _writableState.needDrain.

PR-URL: #8799
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Related: #8686

Member Author

mcollina commented Oct 28, 2016

Fixed in f12338d fd16eed
9ed7261

(I did a mess with the commit SHA in my own fork, it should be ok now).

mcollina closed this as completed

Member Author

mcollina commented Oct 28, 2016

Thanks @italoacasas for your help!!!

evanlucas pushed a commit that referenced this issue


          test: writable stream finished state

d6f688a

Add a test for _writableState.finished.

PR-URL: #8791
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Related: #8686

evanlucas pushed a commit that referenced this issue


          test: writable stream ending state

248a320

Add a test for _writableState.ending, when ending becomes true,
but the stream is not finished/ended yet.

PR-URL: #8707
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Related: #8686

evanlucas pushed a commit that referenced this issue


          test: writable stream needDrain state

c9b67c6

Add a test for _writableState.needDrain.

PR-URL: #8799
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Related: #8686

MylesBorins pushed a commit that referenced this issue


          test: writable stream finished state

a2eedb1

Add a test for _writableState.finished.

PR-URL: #8791
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Related: #8686

MylesBorins pushed a commit that referenced this issue


          test: writable stream ending state

f1ea476

Add a test for _writableState.ending, when ending becomes true,
but the stream is not finished/ended yet.

PR-URL: #8707
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Related: #8686

MylesBorins pushed a commit that referenced this issue


          test: writable stream finished state

80a26c7

Add a test for _writableState.finished.

PR-URL: #8791
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Related: #8686

MylesBorins pushed a commit that referenced this issue


          test: writable stream ending state

ba4a3ed

Add a test for _writableState.ending, when ending becomes true,
but the stream is not finished/ended yet.

PR-URL: #8707
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Related: #8686

MylesBorins pushed a commit that referenced this issue


          test: writable stream needDrain state

4b50419

Add a test for _writableState.needDrain.

PR-URL: #8799
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Related: #8686

MylesBorins pushed a commit that referenced this issue


          test: writable stream needDrain state

40ef239

Add a test for _writableState.needDrain.

PR-URL: #8799
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Related: #8686

MylesBorins pushed a commit that referenced this issue


          test: writable stream finished state

f64d93f

Add a test for _writableState.finished.

PR-URL: #8791
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Related: #8686

MylesBorins pushed a commit that referenced this issue


          test: writable stream ending state

7fbfb73

Add a test for _writableState.ending, when ending becomes true,
but the stream is not finished/ended yet.

PR-URL: #8707
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Related: #8686

MylesBorins pushed a commit that referenced this issue


          test: writable stream needDrain state

1fee6c1

Add a test for _writableState.needDrain.

PR-URL: #8799
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Related: #8686

snyk-bot mentioned this issue

[Snyk] Security upgrade eslint from 3.19.0 to 4.0.0 adamlaska/node#38

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment