Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

investigate flaky parallel/test-debug-signal-cluster on SmartOS #8838

Closed
Trott opened this issue Sep 28, 2016 · 7 comments
Closed

investigate flaky parallel/test-debug-signal-cluster on SmartOS #8838

Trott opened this issue Sep 28, 2016 · 7 comments
Labels
smartos Issues and PRs related to the SmartOS platform. test Issues and PRs related to the tests.

Comments

@Trott
Copy link
Member

Trott commented Sep 28, 2016

https://ci.nodejs.org/job/node-test-commit-smartos/4513/nodes=smartos14-64/console:

not ok 213 parallel/test-debug-signal-cluster
# got pids [62039,62043,62044]
# 
# assert.js:85
#   throw new assert.AssertionError({
#   ^
# AssertionError: test timed out
#     at Object.exports.fail (/home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos14-64/test/common.js:443:10)
#     at Timeout.testTimedOut [as _onTimeout] (/home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos14-64/test/parallel/test-debug-signal-cluster.js:69:10)
#     at Timer.unrefdHandle (timers.js:460:14)
# > all workers are running
# > Starting debugger agent.
# > Debugger listening on 127.0.0.1:12646
# > Starting debugger agent.
# > Debugger listening on 127.0.0.1:12648
# > Starting debugger agent.
  ---
  duration_ms: 7.165
@Trott Trott added debugger test Issues and PRs related to the tests. smartos Issues and PRs related to the SmartOS platform. labels Sep 28, 2016
@cjihrig
Copy link
Contributor

cjihrig commented Sep 29, 2016

cc: @nodejs/platform-solaris

@geek
Copy link
Member

geek commented Sep 29, 2016

@cjihrig thanks, I will take a look

@misterdjules
Copy link

Adding some context which might be helpful.

I had done some work to make this test non-flaky at #8568. In one of the comments of that PR, there are links to stress tests that passed on SmartOS for this test, so it's definitely surprising to see that test fail after my changes landed.

@Trott
Copy link
Member Author

Trott commented Sep 29, 2016

Let's see if a stress test turns anything up on master now:

If it turns up nothing, it may mean that the stress test is not a reliable indicator for this particular case. (Uh, or that something else caused the problem above and it's not directly an issue with the test?)

If it turns up something, it may be useful to run the stress tests again on the commit from @misterdjules that landed to fix this. If that comes up clean, a bisect might be in order to find out where things broke again and hopefully why.

@misterdjules
Copy link

Stress test on master failed for the 64 bits build, started a new stress tests run against the changes that I had landed to fix that problem.

@misterdjules
Copy link

Stress tests against #8568 passed, so it seems a regression might have been introduced between these changes and current master. It's also possible that, if there was a gap between running stress tests for #8568 and landing its changes, some changes landed in between that made this test flaky again.

@Trott
Copy link
Member Author

Trott commented Apr 4, 2017

Debugger is going away on master in the foreseeable future. This is unlikely to be addressed. Closing.

@Trott Trott closed this as completed Apr 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
smartos Issues and PRs related to the SmartOS platform. test Issues and PRs related to the tests.
Projects
None yet
Development

No branches or pull requests

4 participants