-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
investigate flaky parallel/test-debug-signal-cluster on SmartOS #8838
Comments
cc: @nodejs/platform-solaris |
@cjihrig thanks, I will take a look |
Adding some context which might be helpful. I had done some work to make this test non-flaky at #8568. In one of the comments of that PR, there are links to stress tests that passed on SmartOS for this test, so it's definitely surprising to see that test fail after my changes landed. |
Let's see if a stress test turns anything up on master now:
If it turns up nothing, it may mean that the stress test is not a reliable indicator for this particular case. (Uh, or that something else caused the problem above and it's not directly an issue with the test?) If it turns up something, it may be useful to run the stress tests again on the commit from @misterdjules that landed to fix this. If that comes up clean, a bisect might be in order to find out where things broke again and hopefully why. |
Stress test on master failed for the 64 bits build, started a new stress tests run against the changes that I had landed to fix that problem. |
Stress tests against #8568 passed, so it seems a regression might have been introduced between these changes and current master. It's also possible that, if there was a gap between running stress tests for #8568 and landing its changes, some changes landed in between that made this test flaky again. |
Debugger is going away on master in the foreseeable future. This is unlikely to be addressed. Closing. |
https://ci.nodejs.org/job/node-test-commit-smartos/4513/nodes=smartos14-64/console:
The text was updated successfully, but these errors were encountered: